Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(motion_velocity_smoother): velocity limit when engage status #621

Merged

Conversation

mkuri
Copy link
Contributor

@mkuri mkuri commented Apr 1, 2022

Signed-off-by: Makoto Kurihara mkuri8m@gmail.com

Description

velocity-limit-problem

Fixed an issue that when velocity limit is updated during engage status, the velocity limit before the update remains.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
@mkuri mkuri requested review from tkimura4 and rej55 April 1, 2022 08:34
@mkuri
Copy link
Contributor Author

mkuri commented Apr 1, 2022

After this PR.
velcoity-limit-after

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #621 (6af7232) into main (95414c5) will decrease coverage by 10.74%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #621       +/-   ##
==========================================
- Coverage   10.74%   0.00%   -10.75%     
==========================================
  Files         713      10      -703     
  Lines       50671    1776    -48895     
  Branches     6572       0     -6572     
==========================================
- Hits         5443       0     -5443     
+ Misses      40821    1776    -39045     
+ Partials     4407       0     -4407     
Impacted Files Coverage Δ
...ity_smoother/src/motion_velocity_smoother_node.cpp 0.00% <0.00%> (ø)
..._smoother/analytical_jerk_constrained_smoother.cpp 0.00% <0.00%> (ø)
...y_smoother/src/smoother/jerk_filtered_smoother.cpp 0.00% <0.00%> (ø)
..._smoother/src/smoother/l2_pseudo_jerk_smoother.cpp 0.00% <0.00%> (ø)
...moother/src/smoother/linf_pseudo_jerk_smoother.cpp 0.00% <0.00%> (ø)
...n_velocity_smoother/src/smoother/smoother_base.cpp 0.00% <0.00%> (ø)
common/motion_testing/test/trajectory_checks.cpp
...ion/include/shape_estimation/filter/bus_filter.hpp
... and 701 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5153502...6af7232. Read the comment docs.

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit b8f666b into autowarefoundation:main Apr 5, 2022
tkimura4 referenced this pull request in tier4/autoware.universe Apr 6, 2022
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Apr 11, 2022
zhiwango referenced this pull request in tier4/autoware.universe Apr 14, 2022
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
@mkuri mkuri deleted the fix/velocity-limit-when-engage branch November 27, 2022 08:21
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jul 3, 2023
…sage (autowarefoundation#4058) (autowarefoundation#621)

fix(behavior_path_planner): print avoidance and lane change debug mes… (autowarefoundation#4058)

fix(behavior_path_planner): print avoidance and lane change debug message

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
* chore: replace set-output with $GITHUB_OUTPUT

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* Update update-beta-branch.yaml

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants