-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avoidance): turn signal doesn't turn on #6188
fix(avoidance): turn signal doesn't turn on #6188
Conversation
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Screencast.from.2024.01.26.22.13.28.webm
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6188 +/- ##
=======================================
Coverage 14.58% 14.58%
=======================================
Files 1871 1871
Lines 127545 127544 -1
Branches 37311 37313 +2
=======================================
Hits 18606 18606
+ Misses 88019 88018 -1
Partials 20920 20920
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: anhnv3991 <anh.nguyen.2@tier4.jp>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Description
Turn signal doesn't turn on if the adjacent and current lanelet share its previous lanelet.
Screencast.from.2024.01.23.16.14.37.webm
Tests performed
Psim.
Uploading simplescreenrecorder-2024-01-26_18.11.19.mp4…
Effects on system behavior
Fix turn signal bug.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.