Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dynamic_avoidance_planner): inherit modified goal #6179

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jan 25, 2024

Description

inherit modified goal

Tests performed

evaluator_description: fix/dynamic_avoindace_modified_goal
2024/01/26 https://evaluation.tier4.jp/evaluation/reports/33f24db9-516f-5310-afd9-2a1125c16467/?project_id=prd_jt

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 25, 2024
@kosuke55 kosuke55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 25, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2719ad4) 14.58% compared to head (b15926f) 14.58%.
Report is 6 commits behind head on main.

Files Patch % Lines
...ion/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp 0.00% 1 Missing and 1 partial ⚠️
...havior_path_dynamic_avoidance_module/src/scene.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6179   +/-   ##
=======================================
  Coverage   14.58%   14.58%           
=======================================
  Files        1871     1871           
  Lines      127546   127526   -20     
  Branches    37310    37305    -5     
=======================================
  Hits        18606    18606           
+ Misses      88020    88002   -18     
+ Partials    20920    20918    -2     
Flag Coverage Δ *Carryforward flag
differential 6.91% <0.00%> (?)
total 14.59% <0.00%> (+<0.01%) ⬆️ Carriedforward from 98f2a71

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55 kosuke55 merged commit ccd852b into autowarefoundation:main Jan 26, 2024
36 of 39 checks passed
@kosuke55 kosuke55 deleted the fix/dynamic_avoindace_modified_goal branch January 26, 2024 03:54
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Jan 26, 2024
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jan 27, 2024
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jan 28, 2024
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Jan 29, 2024
…tion#6179)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: anhnv3991 <anh.nguyen.2@tier4.jp>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 29, 2024
@xiaoqingdong
Copy link

When can the dynamic_avoidance function be used?

karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants