Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lane_change): add const to lane change functions #6175

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented Jan 25, 2024

Description

Add const to some lane change functions.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 25, 2024
@rej55 rej55 added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) component:planning Route planning, decision-making, and navigation. (auto-assigned) and removed component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jan 25, 2024
@rej55 rej55 enabled auto-merge (squash) January 25, 2024 09:02
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ccd852b) 14.58% compared to head (fe885ff) 14.59%.
Report is 4 commits behind head on main.

Files Patch % Lines
...ing/behavior_path_lane_change_module/src/scene.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6175   +/-   ##
=======================================
  Coverage   14.58%   14.59%           
=======================================
  Files        1871     1871           
  Lines      127545   127523   -22     
  Branches    37311    37302    -9     
=======================================
  Hits        18606    18606           
+ Misses      88019    88000   -19     
+ Partials    20920    20917    -3     
Flag Coverage Δ *Carryforward flag
differential 9.28% <0.00%> (?)
total 14.59% <ø> (+<0.01%) ⬆️ Carriedforward from 92c66a0

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rej55 rej55 merged commit 29faba5 into autowarefoundation:main Jan 26, 2024
22 of 24 checks passed
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Jan 29, 2024
…undation#6175)

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: anhnv3991 <anh.nguyen.2@tier4.jp>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 29, 2024
rej55 added a commit to tier4/autoware.universe that referenced this pull request Feb 9, 2024
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Feb 22, 2024
…undation#6175)

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
satoshi-ota pushed a commit to tier4/autoware.universe that referenced this pull request Feb 23, 2024
…undation#6175)

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
satoshi-ota pushed a commit to tier4/autoware.universe that referenced this pull request Feb 23, 2024
…undation#6175)

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants