Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(object_velocity_splitter): rework parameters #6158

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jan 24, 2024

Description

Add a parameter file.
Must be merged with autowarefoundation/autoware_launch#820

Tests performed

  • Launched a node individually and confirmed that it loads the parameter as expected
  • Launch Autoware with perception_mode = radar, and confirmed that the velocity_threshold is loaded as 5.5.
  • Launch Autoware with perception_mode = lidar_radar_fusion, and confirmed that the velocity_threshold is loaded as 4.5.
  • Launch Autoware with perception_mode = camera_lidar_radar_fusion, and confirmed that the velocity_threshold is loaded as 4.5.

Effects on system behavior

No effect expected

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 24, 2024
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 25, 2024
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jan 25, 2024
@kminoda kminoda marked this pull request as ready for review January 25, 2024 01:51
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b1a414) 14.40% compared to head (0952fa2) 14.62%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6158      +/-   ##
==========================================
+ Coverage   14.40%   14.62%   +0.22%     
==========================================
  Files        1906     1868      -38     
  Lines      129849   126937    -2912     
  Branches    37572    37044     -528     
==========================================
- Hits        18699    18566     -133     
+ Misses      90156    87504    -2652     
+ Partials    20994    20867     -127     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.62% <ø> (+0.22%) ⬆️ Carriedforward from 54f1796

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda kminoda changed the title chore(object_velocity_splitter): add config chore(object_velocity_splitter): rework parameters Jan 25, 2024
Copy link
Contributor

@scepter914 scepter914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda merged commit 17a3070 into autowarefoundation:main Jan 31, 2024
22 of 25 checks passed
@kminoda kminoda deleted the chore/object_velocity_splitter/add_config branch January 31, 2024 13:04
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…n#6158)

* chore(object_velocity_splitter): add param file

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* fix arg name

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* fix: update launch param handling

Signed-off-by: kminoda <koji.minoda@tier4.jp>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants