Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(localization_error_monitor): rework parameters #6156

Conversation

YamatoAndo
Copy link
Contributor

@YamatoAndo YamatoAndo commented Jan 24, 2024

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371.

  • Remove the default value from the source code in order to ensure all parameter values are passed from the parameter files.
    • already completed.
  • Create the yaml configs in this package and the autoware_launch repository.
    • already completed.
  • Create the schema.
    • This PR.
  • Update Parameters chapter in the readme file.
    • This PR.

Tests performed

Confirm that the parameters in the autoware_launch are being applied.

test example

input parameters

/**:
  ros__parameters:
    scale: 3.012
    error_ellipse_size: 1.534
    warn_ellipse_size: 1.256
    error_ellipse_size_lateral_direction: 0.367
    warn_ellipse_size_lateral_direction: 0.2591

result

ros2 param dump /localization/localization_error_monitor
/localization/localization_error_monitor:
  ros__parameters:
    error_ellipse_size: 1.534
    error_ellipse_size_lateral_direction: 0.367
    qos_overrides:
      /clock:
        subscription:
          depth: 1
          durability: volatile
          history: keep_last
          reliability: best_effort
      /parameter_events:
        publisher:
          depth: 1000
          durability: volatile
          history: keep_last
          reliability: reliable
    scale: 3.012
    use_sim_time: true
    warn_ellipse_size: 1.256
    warn_ellipse_size_lateral_direction: 0.2591

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) labels Jan 24, 2024
Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@YamatoAndo YamatoAndo added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4cae6f) 14.58% compared to head (26c1751) 14.58%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6156   +/-   ##
=======================================
  Coverage   14.58%   14.58%           
=======================================
  Files        1868     1868           
  Lines      127493   127493           
  Branches    37317    37317           
=======================================
  Hits        18600    18600           
  Misses      87974    87974           
  Partials    20919    20919           
Flag Coverage Δ *Carryforward flag
differential 21.35% <ø> (?)
total 14.58% <ø> (ø) Carriedforward from e4cae6f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YamatoAndo YamatoAndo merged commit 6bf7532 into autowarefoundation:main Jan 25, 2024
34 of 36 checks passed
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 26, 2024
…dation#6156)

* refactor(localization_error_monitor): rework parameters

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…dation#6156)

* refactor(localization_error_monitor): rework parameters

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants