Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_automatic_goal_rviz_plugin): make it possible to register checkpoints #6153

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jan 24, 2024

Description

Make it possible to register checkpoints. (Previously, only goal point was supported.)

How to use

  1. Open AutowareAutomaticGoalPanel
  2. Show markers outputted from AutowareAutomaticGoalPanel
  3. Add goal pose by AutomaticGoalAppendTool
  4. Select goal which you want to add checkpoint
  5. Add goal pose by AutomaticCheckpointAppendTool
simplescreenrecorder-2024-01-24_16.36.17.mp4

Tests performed

Please select goal before adding checkpoints. Checkpoints is added to route to the goal.

image

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Jan 24, 2024
@satoshi-ota satoshi-ota marked this pull request as ready for review January 24, 2024 07:46
…checkpoints

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the feat/pub-auto-goal-with-checkpoint branch from 36fb912 to 6c178c2 Compare January 24, 2024 07:48
@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 24, 2024
@kyoichi-sugahara kyoichi-sugahara self-assigned this Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 103 lines in your changes are missing coverage. Please review.

Comparison is base (e4cae6f) 14.58% compared to head (6c178c2) 14.58%.
Report is 3 commits behind head on main.

Files Patch % Lines
...atic_goal_rviz_plugin/src/automatic_goal_panel.cpp 0.00% 54 Missing ⚠️
...iz_plugin/src/automatic_checkpoint_append_tool.cpp 0.00% 40 Missing ⚠️
...tic_goal_rviz_plugin/src/automatic_goal_sender.hpp 0.00% 6 Missing ⚠️
...tic_goal_rviz_plugin/src/automatic_goal_sender.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6153      +/-   ##
==========================================
- Coverage   14.58%   14.58%   -0.01%     
==========================================
  Files        1868     1869       +1     
  Lines      127493   127557      +64     
  Branches    37317    37317              
==========================================
  Hits        18600    18600              
- Misses      87974    88038      +64     
  Partials    20919    20919              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.59% <ø> (+<0.01%) ⬆️ Carriedforward from e4cae6f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk
Copy link
Contributor

shmpwk commented Jan 24, 2024

FYI @mehmetdogru @MertClk

@satoshi-ota satoshi-ota merged commit 1aba0ac into autowarefoundation:main Jan 24, 2024
30 of 33 checks passed
@satoshi-ota satoshi-ota deleted the feat/pub-auto-goal-with-checkpoint branch January 24, 2024 23:32
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…checkpoints (autowarefoundation#6153)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants