Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(imu_corrector): changed publication algorithm and content of /diagnostics in gyro_bias_estimator #6139

Merged
merged 17 commits into from
Jan 29, 2024
Merged

feat(imu_corrector): changed publication algorithm and content of /diagnostics in gyro_bias_estimator #6139

merged 17 commits into from
Jan 29, 2024

Commits on Jan 19, 2024

  1. Let diagnostics be updated even if expections occur in timer_callback 

    Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
    @TaikiYamada4
    TaikiYamada4 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    2bc4949 View commit details
    Browse the repository at this point in the history

  2. Fixed the summary message to be "Not updated" when the gyro bias is n… 

    …ot updated.

Fixed typo.

Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
    @TaikiYamada4
    TaikiYamada4 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    4d9627e View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Removed force_update() since updater_ originaly updates diagnostics a… 

    …utomatically.

Set the update peirod of diagnostics to be same to the timer_callback.
Changed words of the diagnostics message a bit.

Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
    @TaikiYamada4
    TaikiYamada4 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    818f636 View commit details
    Browse the repository at this point in the history

  2. style(pre-commit): autofix

    @pre-commit-ci
    pre-commit-ci[bot] committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    a1b84b5 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Let the period of diagnostics publication independent to timer. 

    Let update_diagnostics to be simple.

Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
    @TaikiYamada4
    TaikiYamada4 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    320047d View commit details
    Browse the repository at this point in the history

  2. style(pre-commit): autofix

    @pre-commit-ci
    pre-commit-ci[bot] committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    639c2c4 View commit details
    Browse the repository at this point in the history

  3. Fixed typo 

    Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
    @TaikiYamada4
    TaikiYamada4 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    524c5ad View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feat/gyro_bias_estimator-periodical_diag' of github.com… 

    …:TaikiYamada4/autoware.universe into feat/gyro_bias_estimator-periodical_diag

Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
    @TaikiYamada4
    TaikiYamada4 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    bec9b1e View commit details
    Browse the repository at this point in the history

  5. style(pre-commit): autofix

    @pre-commit-ci
    pre-commit-ci[bot] committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    270c58b View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Added setPeriod after force_update to reset the timer of updater_. 

    Then, there will be no duplicates of diagnostics.

Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
    @TaikiYamada4
    TaikiYamada4 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    71eadc2 View commit details
    Browse the repository at this point in the history

  2. style(pre-commit): autofix

    @pre-commit-ci
    pre-commit-ci[bot] committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    a02f897 View commit details
    Browse the repository at this point in the history

  3. Set diagnostics values to have the same precision 

    Added gyro_bias_threshold_ to the diagnostics

Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
    @TaikiYamada4
    TaikiYamada4 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    94ccc95 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Merge branch 'main' into feat/gyro_bias_estimator-periodical_diag

    @TaikiYamada4
    TaikiYamada4 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    32ec8b6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feat/gyro_bias_estimator-periodical_diag

    @TaikiYamada4
    TaikiYamada4 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    2aaa115 View commit details
    Browse the repository at this point in the history

  3. Updated README.md to match the paramters in gyro_bias_estimator 

    Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
    @TaikiYamada4
    TaikiYamada4 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    714fece View commit details
    Browse the repository at this point in the history

  4. style(pre-commit): autofix

    @pre-commit-ci
    pre-commit-ci[bot] committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    0b92a8b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into feat/gyro_bias_estimator-periodical_diag

    @TaikiYamada4
    TaikiYamada4 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    d34a6c9 View commit details
    Browse the repository at this point in the history