Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(intersection): divide source files and modifyPathVelocity #6134

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Jan 22, 2024

Description

refactored the source code

Related links

Tests performed

evaluator https://evaluation.tier4.jp/evaluation/reports/7b7cd789-319b-54d6-ba98-4c62304f64bc?project_id=prd_jt

  • stuck/yield-stuck
PR6047-2024-01-22_16.37.28.mp4
  • collision + stuck
PR6047-2024-01-22_16.42.43.mp4
  • occlusion
PR6047-2024-01-22_17.04.18.mp4

Notes for reviewers

Interface changes

none.

Effects on system behavior

none.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 22, 2024
@soblin soblin force-pushed the refactor/intersection/add-comment branch from c7475be to 93871aa Compare January 22, 2024 07:53
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the refactor/intersection/add-comment branch from 93871aa to c6a4395 Compare January 22, 2024 08:06
@soblin soblin changed the title refactor(intersection): divide modifyPathVelocity and files refactor(intersection): divide source files and modifyPathVelocity Jan 22, 2024
@soblin soblin marked this pull request as ready for review January 22, 2024 10:01
@soblin soblin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 1043 lines in your changes are missing coverage. Please review.

Comparison is base (454e19d) 14.61% compared to head (c6a4395) 14.45%.
Report is 9 commits behind head on main.

Files Patch % Lines
...ion_module/src/scene_intersection_prepare_data.cpp 0.00% 358 Missing ⚠️
...ection_module/src/scene_intersection_collision.cpp 0.00% 270 Missing ⚠️
...ection_module/src/scene_intersection_occlusion.cpp 0.00% 179 Missing ⚠️
...tersection_module/src/scene_intersection_stuck.cpp 0.00% 156 Missing ⚠️
..._intersection_module/src/intersection_lanelets.cpp 0.00% 34 Missing ⚠️
...behavior_velocity_intersection_module/src/util.cpp 0.00% 18 Missing ⚠️
...locity_intersection_module/src/decision_result.hpp 0.00% 14 Missing ⚠️
..._intersection_module/src/intersection_lanelets.hpp 0.00% 11 Missing ⚠️
...avior_velocity_intersection_module/src/manager.cpp 0.00% 1 Missing ⚠️
...havior_velocity_intersection_module/src/result.hpp 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6134      +/-   ##
==========================================
- Coverage   14.61%   14.45%   -0.16%     
==========================================
  Files        1860     1869       +9     
  Lines      127417   128784    +1367     
  Branches    37286    38137     +851     
==========================================
- Hits        18619    18618       -1     
- Misses      87885    89233    +1348     
- Partials    20913    20933      +20     
Flag Coverage Δ *Carryforward flag
differential 5.07% <0.00%> (?)
total 14.61% <ø> (+<0.01%) ⬆️ Carriedforward from 454e19d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 3019aab into autowarefoundation:main Jan 22, 2024
35 of 39 checks passed
@soblin soblin deleted the refactor/intersection/add-comment branch January 22, 2024 18:02
soblin added a commit to tier4/autoware.universe that referenced this pull request Jan 23, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 23, 2024
soblin added a commit to tier4/autoware.universe that referenced this pull request Jan 29, 2024
soblin added a commit to tier4/autoware.universe that referenced this pull request Feb 6, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants