-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(intersection): divide source files and modifyPathVelocity #6134
Merged
soblin
merged 3 commits into
autowarefoundation:main
from
tier4:refactor/intersection/add-comment
Jan 22, 2024
Merged
refactor(intersection): divide source files and modifyPathVelocity #6134
soblin
merged 3 commits into
autowarefoundation:main
from
tier4:refactor/intersection/add-comment
Jan 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Jan 22, 2024
soblin
force-pushed
the
refactor/intersection/add-comment
branch
from
January 22, 2024 07:53
c7475be
to
93871aa
Compare
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
force-pushed
the
refactor/intersection/add-comment
branch
from
January 22, 2024 08:06
93871aa
to
c6a4395
Compare
soblin
changed the title
refactor(intersection): divide modifyPathVelocity and files
refactor(intersection): divide source files and modifyPathVelocity
Jan 22, 2024
soblin
requested review from
kyoichi-sugahara,
shmpwk,
takayuki5168 and
tkimura4
as code owners
January 22, 2024 10:01
takayuki5168
approved these changes
Jan 22, 2024
soblin
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jan 22, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6134 +/- ##
==========================================
- Coverage 14.61% 14.45% -0.16%
==========================================
Files 1860 1869 +9
Lines 127417 128784 +1367
Branches 37286 38137 +851
==========================================
- Hits 18619 18618 -1
- Misses 87885 89233 +1348
- Partials 20913 20933 +20
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 23, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Jan 23, 2024
…utowarefoundation#6134) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 29, 2024
…utowarefoundation#6134) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
7 tasks
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 6, 2024
…utowarefoundation#6134) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 6, 2024
feat(intersection): cherry pick intersection (autowarefoundation#6047 + autowarefoundation#6134+ autowarefoundation#6143 + autowarefoundation#6201 + autowarefoundation#6207 + autowarefoundation#6272 + autowarefoundation#6315)
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…utowarefoundation#6134) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactored the source code
Related links
Tests performed
evaluator https://evaluation.tier4.jp/evaluation/reports/7b7cd789-319b-54d6-ba98-4c62304f64bc?project_id=prd_jt
PR6047-2024-01-22_16.37.28.mp4
PR6047-2024-01-22_16.42.43.mp4
PR6047-2024-01-22_17.04.18.mp4
Notes for reviewers
Interface changes
none.
Effects on system behavior
none.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.