Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(motion_velocity_smoother): Add constructor for setting params from node instance #606

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Mar 30, 2022

Signed-off-by: Makoto Kurihara mkuri8m@gmail.com
Signed-off-by: tanaka3 ttatcoder@outlook.jp

Description

https://github.com/mkuri/autoware.universe/tree/feature/load-smoother-params-from-node-instance
refactor smoother load param function to call from other packages

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@taikitanaka3 taikitanaka3 changed the title feat(motion_velocity_smoother) constructor for setting params from node instance feat(motion_velocity_smoother): Add constructor for setting params from node instance Mar 30, 2022
@taikitanaka3 taikitanaka3 force-pushed the feat-velocity-smoother-load-param branch from 3458c6f to 7f6aa39 Compare March 30, 2022 05:44
… instance

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #606 (9faeac5) into main (ca59048) will decrease coverage by 10.76%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #606       +/-   ##
==========================================
- Coverage   10.76%   0.00%   -10.77%     
==========================================
  Files         712      10      -702     
  Lines       50569    1849    -48720     
  Branches     6572       0     -6572     
==========================================
- Hits         5445       0     -5445     
+ Misses      40717    1849    -38868     
+ Partials     4407       0     -4407     
Impacted Files Coverage Δ
..._smoother/analytical_jerk_constrained_smoother.cpp 0.00% <0.00%> (ø)
...n_velocity_smoother/src/smoother/smoother_base.cpp 0.00% <0.00%> (ø)
...city_planner/include/utilization/marker_helper.hpp
...ms/test/src/test_freespace_planning_algorithms.cpp
...nal_processing/test/src/lowpass_filter_1d_test.cpp
..._path_planner/src/scene_module/side_shift/util.cpp
...re_utils/test/src/geometry/test_pose_deviation.cpp
...rception/tensorrt_yolo/lib/include/mish_plugin.hpp
...apollo_instance_segmentation/lib/include/Utils.hpp
...stacle_avoidance_planner/src/eb_path_optimizer.cpp
... and 694 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca59048...9faeac5. Read the comment docs.

@taikitanaka3 taikitanaka3 force-pushed the feat-velocity-smoother-load-param branch from 7f6aa39 to 9faeac5 Compare March 30, 2022 05:49
@taikitanaka3 taikitanaka3 marked this pull request as draft March 30, 2022 05:49
@taikitanaka3 taikitanaka3 deleted the feat-velocity-smoother-load-param branch April 3, 2022 04:31
asana17 pushed a commit to asana17/autoware.universe that referenced this pull request Jul 26, 2023
…ure monitor (autowarefoundation#606)

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant