feat(rviz_plugin): console meter is too large on the Rviz with FHD display, isn't it? #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #587 +/- ##
========================================
- Coverage 9.57% 9.54% -0.03%
========================================
Files 939 939
Lines 58181 58355 +174
Branches 10638 10638
========================================
Hits 5570 5570
- Misses 47892 48066 +174
Partials 4719 4719
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
yukkysaito
reviewed
Mar 28, 2022
|
@TakaHoribe Are you still working on this PR? |
|
@wep21 I didn't touch this PR recently but will make it. I would be appreciated if someone could help. |
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
|
now i'm taking it |
TakaHoribe
force-pushed
the
feature/rviz-plugin-scaling
branch
from
e64e113
to
6dc12a9
Compare
4 tasks
|
@wep21 @yukkysaito now it is ready for review |
|
FHD 4K |
|
LGTM Ultra wide display |
yukkysaito
approved these changes
May 25, 2022
ktro2828
pushed a commit
to ktro2828/autoware.universe
that referenced
this pull request
Jun 7, 2022
…splay, isn't it? (autowarefoundation#587) * feat(tier4_planning/vehicle_plugin): make plugins size scalable Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove space Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * scaling Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
boyali
referenced
this pull request
in boyali/autoware.universe
Sep 28, 2022
…splay, isn't it? (tier4#587) * feat(tier4_planning/vehicle_plugin): make plugins size scalable Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove space Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * scaling Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
…splay, isn't it? (tier4#587) * feat(tier4_planning/vehicle_plugin): make plugins size scalable Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove space Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * scaling Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
…splay, isn't it? (tier4#587) * feat(tier4_planning/vehicle_plugin): make plugins size scalable Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove space Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * scaling Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 19, 2022
…splay, isn't it? (tier4#587) * feat(tier4_planning/vehicle_plugin): make plugins size scalable Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove space Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * scaling Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
satoshi-ota
pushed a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Jun 23, 2023
…0.8.1 feat(behavior_path_planner): use module status idle before approval and keep candiate running module when approved module succeed autowarefoundation#3928
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: must be merged with autowarefoundation/autoware_launch#44
Description
I wanted to adjust the size of the plugins to our screen size.
I modified the default size so that these plugins are displayed at smaller sizes on a screen smaller than 4k.
Note: I'm not satisfied with my approach. (Although I hate the current size more.) Any better solution is welcome.
Now on FHD: Steering, you are not the main character.
With this PR. It's cool. Nice.
on 4k.
on FHD.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.