Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): discard envelope polygon if the objects move long distance #5388

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Oct 24, 2023

Description

🤖 Generated by Copilot at a06110d

Improved object avoidance logic in behavior_path_planner by using a different envelope polygon function for large motion changes. Renamed and updated utils.cpp accordingly.

Before this PR:

The envelope polygon continues to expand while the object is detected as target even if the object moves a few meter. This may cause unnecessary avoidance maneuver.

simplescreenrecorder-2023-10-25_18.59.56.mp4

After this PR:

The envelope polygon is reset if the latest envelope polygon is larger than threshold.

simplescreenrecorder-2023-10-25_18.52.30.mp4

Tests performed

Effects on system behavior

Improve avoidance maneuver.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 24, 2023
…tance

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 25, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review October 25, 2023 10:20
@kyoichi-sugahara kyoichi-sugahara self-assigned this Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (d6be0d2) 14.75% compared to head (cdd282a) 14.81%.
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5388      +/-   ##
==========================================
+ Coverage   14.75%   14.81%   +0.05%     
==========================================
  Files        1661     1661              
  Lines      115525   117493    +1968     
  Branches    35671    37164    +1493     
==========================================
+ Hits        17047    17401     +354     
- Misses      79231    80503    +1272     
- Partials    19247    19589     +342     
Flag Coverage Δ *Carryforward flag
differential 12.15% <9.09%> (?)
total 14.75% <ø> (+<0.01%) ⬆️ Carriedforward from bde24c1

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
planning/behavior_path_planner/src/utils/utils.cpp 15.47% <0.00%> (+1.73%) ⬆️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 12.73% <14.28%> (+1.24%) ⬆️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

satoshi-ota and others added 2 commits October 31, 2023 17:56
Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
@satoshi-ota satoshi-ota enabled auto-merge (squash) October 31, 2023 08:57
@satoshi-ota satoshi-ota merged commit 9628276 into autowarefoundation:main Oct 31, 2023
27 of 28 checks passed
@satoshi-ota satoshi-ota deleted the feat/update-envelope-polygon branch October 31, 2023 09:30
kyoichi-sugahara added a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Nov 1, 2023
…tance (autowarefoundation#5388)

* fix(avoidance): discard envelope polygon if the objects move long distance

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* Update planning/behavior_path_planner/src/utils/avoidance/utils.cpp

Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>

* Update planning/behavior_path_planner/src/utils/avoidance/utils.cpp

Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Nov 14, 2023
…tance (autowarefoundation#5388)

* fix(avoidance): discard envelope polygon if the objects move long distance

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* Update planning/behavior_path_planner/src/utils/avoidance/utils.cpp

Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>

* Update planning/behavior_path_planner/src/utils/avoidance/utils.cpp

Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Nov 14, 2023
…tance (autowarefoundation#5388) (#1013)

* fix(avoidance): discard envelope polygon if the objects move long distance



* Update planning/behavior_path_planner/src/utils/avoidance/utils.cpp



* Update planning/behavior_path_planner/src/utils/avoidance/utils.cpp



---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants