fix(intersection): fix unsigned subtraction #5280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
github-actions
bot
added
the
component:planning
takayuki5168
approved these changes
Oct 12, 2023
soblin
requested review from
kyoichi-sugahara,
shmpwk and
tkimura4
as code owners
soblin
added
the
tag:run-build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5280 +/- ##
========================================
Coverage 14.84% 14.84%
========================================
Files 1649 1649
Lines 114166 114386 +220
Branches 35323 35517 +194
========================================
+ Hits 16943 16977 +34
- Misses 78102 78260 +158
- Partials 19121 19149 +28
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
7 tasks
|
This PR fixes #5264 |
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 12, 2023
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
4 tasks
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 20, 2023
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the error caused by unsigned subtraction
Related links
Tests performed
https://evaluation.tier4.jp/evaluation/reports/1b310650-c475-5c8d-a468-a5b5c3a701cc?project_id=prd_jt
Notes for reviewers
none.
Interface changes
none.
Effects on system behavior
none.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.