chore: save engine file in the same directory as onnx file #519

wep21 · 2022-03-15T05:41:52Z

Signed-off-by: wep21 border_goldenmarket@yahoo.co.jp

Related Issue(required)

Description(required)

save an engine file in the same directory as an onnx file to handle the model files in the directory which is different from the default location.

Review Procedure(required)

launch with the model path argument and confirm an engine file is created in the same directory as an onnx file.

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Read commit-guidelines
Assign PR to reviewer

If you are adding new package following items are required:

Documentation with description of the package is available
A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

Commits are properly organized and messages are according to the guideline
PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

All open points are addressed and tracked via issues or tickets

CI Checks

Build and test for PR / build-and-test-pr: Required to pass before the merge.
Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

codecov · 2022-03-15T05:49:07Z

Codecov Report

Merging #519 (d15de05) into main (fa2bca8) will decrease coverage by 10.97%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #519       +/-   ##
==========================================
- Coverage   10.97%   0.00%   -10.98%     
==========================================
  Files         705      11      -694     
  Lines       49781     687    -49094     
  Branches     7119       0     -7119     
==========================================
- Hits         5462       0     -5462     
+ Misses      39933     687    -39246     
+ Partials     4386       0     -4386

Impacted Files	Coverage Δ
...on/traffic_light_classifier/src/cnn_classifier.cpp	`0.00% <0.00%> (ø)`
...tion/traffic_light_classifier/utils/trt_common.cpp	`0.00% <0.00%> (ø)`
...tion/traffic_light_classifier/utils/trt_common.hpp	`0.00% <ø> (ø)`
...on/traffic_light_ssd_fine_detector/src/nodelet.cpp	`0.00% <0.00%> (ø)`
common/motion_testing/test/trajectory_checks.cpp
...eption/tensorrt_yolo/lib/src/plugins/yolo_layer.cu
...ulator/vehicle_model/sim_model_delay_steer_acc.hpp
...r4_planning_rviz_plugin/src/trajectory/display.cpp
...anning_evaluator/src/metrics/deviation_metrics.cpp
...trol/trajectory_follower/test/test_interpolate.cpp
... and 688 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa2bca8...d15de05. Read the comment docs.

taichiH

LGTM

tkimura4

LGTM

kenji-miyake · 2022-03-15T11:04:28Z

perception/traffic_light_classifier/utils/trt_common.cpp

+#else
+#include <experimental/filesystem>
+namespace fs = ::std::experimental::filesystem;
+#endif


@wep21 Why did you need this in spite of using C++17? 🤔

* release v0.4.0 * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit a2dc52036f5950188b5b4caedb2edcd36d3e5860. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * ROS2 Porting: raw_vehicle_cmd_converter (#9) * remove dependency to unused std_msgs package Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * rm COLCON_IGNORE Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * port raw_vehicle_cmd_converter to ROS2 Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * port raw_vehicle_cmd_converter.launch to ROS2 Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * fix typo Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com> * fix typo Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com> * remove include_directories form CMakeLists.txt Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * fix order of includes Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add missing comments Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com> * fix duration unit for RCLCPP_*_THROTTLE (autowarefoundation#75) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Rename h files to hpp (autowarefoundation#142) * Change includes * Rename files * Adjustments to make things compile * Other packages * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151) * Run uncrustify on the entire Pilot.Auto codebase * Exclude open PRs * ROS2 Linting: raw_vehicle_cmd_converter (autowarefoundation#161) * Add linters * Process linter corrections * apply env_var to use_sim_time (autowarefoundation#222) * Ros2 v0.8.0 raw vehicle cmd converter (autowarefoundation#268) * restore raw_vehicle_cmd_converter files for 0.8.0 update Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix typos in vehicle modules (autowarefoundation#954) * add get func (autowarefoundation#1088) * Revert "restore raw_vehicle_cmd_converter files for 0.8.0 update" This reverts commit f243f26e20490757a332566aa92196553a682aa6. Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * update target branch for ci (autowarefoundation#309) * update target branch for ci Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * [as]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [latlon_muxer]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [map_based_prediction]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [raw_vehicle_cmd_converter]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [remote_cmd_converter]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [turn_signal_decider]: Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * Unify Apache-2.0 license name (autowarefoundation#1242) * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * add plot_accel_brake_map.py (autowarefoundation#1249) (autowarefoundation#1296) * add plot_accel_brake_map.py (autowarefoundation#1249) * add plot_accel_brake_map.py * call plotter from rosrun * add permission Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * delete debug message * Add license Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * apply format * fix code Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: tomoya.kimura <tomoya.kimura@tier4.jp> * Fix lint errors (autowarefoundation#1378) * Fix lint errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix variable names Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * enable to designate directory of maps (autowarefoundation#1301) (autowarefoundation#1480) * enable to designate directory of maps * add error handling * use argparser Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * Feature/vehicle interface improvements (autowarefoundation#1361) (autowarefoundation#1688) * Feature/vehicle interface improvements (autowarefoundation#1361) * add vehicle msg * add pacmod interface * add eps controller * use each control commands instead of vehicle command * fixed details * fixed speell check * const * fixed brake status * publish cmd when recieving ctrl cmd * fix shift cmd ptr * remove unused function and set proper license * fix names * fix typo for pacmod * remove unnecessary waiting * use flags, limit, multiarray * remove accel brake dependency * fix retrun value * replace eps to steer * cosmetic change for namespace * fix segfo and retval * Use Enum instead of int * remove unused var * add const * rename to calcFFMap * prev time steer calc * add sample csv * add new line Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Apply lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix build failure for remote cmd converter Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * replace to vehicle cmd emergency (autowarefoundation#1710) (autowarefoundation#1717) * Fix subscriber topic type Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * Fix rclcpp::Time initialization Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * default debug value false in raw vehicle cmd converter (autowarefoundation#1755) * default debug value false in raw vehicle cmd converter * spell check * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * [raw vehicle cmd converter] apply autoware auto msgs (autowarefoundation#519) * remove ignore * replace to autoware auto control message * use localization odometry * apply steering report * appluy clang format * cosmetic change * fix spell check * update to readme * update launch * minor fix * precommit fix * update README.md Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * using AckermannControlCommand * fix format Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * move cmd converters to control pkg (autowarefoundation#642) * auto/revert cmd converter (autowarefoundation#680) * Revert "move cmd converters to control pkg (autowarefoundation#642)" This reverts commit 19a10f9419aa25ef7a37e51c5df8f65b75cf8887. * fix topic * Auto/readme cmd converter (autowarefoundation#692) * fix format * add readme external cmd converter * fix lint * fiix sentence Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * fix format Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * fix sentence Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * better expression Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * fix door cmd topic (autowarefoundation#711) * fix door cmd topic * fix topic Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: Jilada Eccleston <jilada.eccleston@gmail.com> Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Keisuke Shima <keisuke.shima@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

…undation#3801) (autowarefoundation#519) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat: add dependency package to simulator.repos * chore: change directory * chore: add directory

chore: save engine file in the same directory as onnx file

d15de05

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

wep21 requested a review from kenji-miyake March 15, 2022 05:42

taichiH approved these changes Mar 15, 2022

View reviewed changes

wep21 requested a review from tkimura4 March 15, 2022 07:30

tkimura4 approved these changes Mar 15, 2022

View reviewed changes

tkimura4 merged commit ebde6f9 into autowarefoundation:main Mar 15, 2022

wep21 deleted the feature/engine-save-path branch March 15, 2022 08:16

kenji-miyake reviewed Mar 15, 2022

View reviewed changes

tier4-autoware-public-bot bot mentioned this pull request Mar 16, 2022

chore: sync upstream tier4/autoware.universe#20

Merged

boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022

chore: save engine file in the same directory as onnx file (tier4#519)

e0b443f

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022

chore: save engine file in the same directory as onnx file (tier4#519)

6b035ec

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022

chore: save engine file in the same directory as onnx file (tier4#519)

b49e07c

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

kosuke55 added a commit to kosuke55/autoware.universe that referenced this pull request May 29, 2023

fix(goal_planner): add buffer to stop_pose for restarting (autowarefo…

ab3dafb

…undation#3801) (autowarefoundation#519) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023

feat: add dependency package to simulator.repos (#519)

1b36f47

* feat: add dependency package to simulator.repos * chore: change directory * chore: add directory

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: save engine file in the same directory as onnx file #519

chore: save engine file in the same directory as onnx file #519

wep21 commented Mar 15, 2022

codecov bot commented Mar 15, 2022

taichiH left a comment

tkimura4 left a comment

kenji-miyake Mar 15, 2022

chore: save engine file in the same directory as onnx file #519

chore: save engine file in the same directory as onnx file #519

Conversation

wep21 commented Mar 15, 2022

Related Issue(required)

Description(required)

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

Checklist for the PR Reviewer

Post-Review Checklist for the PR Author

CI Checks

codecov bot commented Mar 15, 2022

Codecov Report

taichiH left a comment

Choose a reason for hiding this comment

tkimura4 left a comment

Choose a reason for hiding this comment

kenji-miyake Mar 15, 2022

Choose a reason for hiding this comment