Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_perception_launch): camera lidar fusion launch #4983

Merged

Conversation

miursh
Copy link
Contributor

@miursh miursh commented Sep 13, 2023

Description

Hotfix: In order to properly connect the topics, remove unnecessary nodes.

Related links

tier4#833

Tests performed

Confirmed the prediction object is being output, using logging.simulator.launch in camera_lidar_fusion mode
image

Notes for reviewers

Interface changes

No changes

Effects on system behavior

Output perception correctly in camera_lidar_fusion mode

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Sep 13, 2023
@miursh miursh added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 13, 2023
Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
It was my mistake when changing from DetectedObjects output to Clusters output.
@miursh I appoligize for my mistake. Thank you for your fixing.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh merged commit 6e510b4 into autowarefoundation:main Sep 14, 2023
33 checks passed
@miursh miursh deleted the fix/camera_lidar_fusion_launch branch September 14, 2023 01:15
badai-nguyen pushed a commit to tier4/autoware.universe that referenced this pull request Sep 19, 2023
…ndation#4983)

fix: camera lidar fusion launch

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants