Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): add virtual stop wall for lane change #4808

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented Aug 30, 2023

Description

I add the virtual stop wall for lane change.

Ego vehicle has to stop behind of the end of lane to reserve minimum lane change length if lane change is necessary.
In this change, I set the virtual stop wall at the point.

Related links

Tests performed

Tested in planning simulator.

image

Notes for reviewers

Interface changes

Nothing.

Effects on system behavior

Virtual stop wall for lane change will be shown in rviz.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 30, 2023
@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 30, 2023
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
@rej55 rej55 force-pushed the feat/lane_change_stop_wall branch from 9822c82 to 649c1c5 Compare August 30, 2023 05:06
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5f04a37) 15.12% compared to head (0f69b60) 15.13%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #4808    +/-   ##
========================================
  Coverage   15.12%   15.13%            
========================================
  Files        1573     1571     -2     
  Lines      108302   108121   -181     
  Branches    33269    33177    -92     
========================================
- Hits        16386    16363    -23     
+ Misses      74067    73933   -134     
+ Partials    17849    17825    -24     
Flag Coverage Δ *Carryforward flag
differential 13.02% <0.00%> (?)
total 15.13% <ø> (+<0.01%) ⬆️ Carriedforward from 649c1c5

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
.../ar_tag_based_localizer/src/tag_tf_caster_core.cpp 0.00% <ø> (ø)
...let2_map_preprocessor/src/fix_lane_change_tags.cpp 0.00% <ø> (ø)
...raffic_light_arbiter/src/traffic_light_arbiter.cpp 0.00% <ø> (ø)
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp 0.00% <0.00%> (ø)
.../scene_module/goal_planner/goal_planner_module.hpp 9.09% <ø> (ø)
...th_planner/scene_module/lane_change/base_class.hpp 15.55% <ø> (ø)
...r_path_planner/scene_module/lane_change/normal.hpp 0.00% <ø> (ø)
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% <0.00%> (ø)
...ner/src/scene_module/dynamic_avoidance/manager.cpp 0.00% <ø> (ø)
.../scene_module/goal_planner/goal_planner_module.cpp 6.37% <0.00%> (-0.14%) ⬇️
... and 3 more

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rej55 rej55 merged commit b09f309 into autowarefoundation:main Aug 31, 2023
22 of 24 checks passed
@rej55 rej55 deleted the feat/lane_change_stop_wall branch August 31, 2023 05:45
rej55 added a commit to tier4/autoware.universe that referenced this pull request Sep 25, 2023
rej55 added a commit to tier4/autoware.universe that referenced this pull request Sep 27, 2023
rej55 added a commit to tier4/autoware.universe that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants