Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(dummy_perception): change leaf size and disable ray trace #468

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Mar 2, 2022

Related Issue(required)

without raytrace occupancy grid looks good but with raytrace leaf size is sensitive. as shown in #413
However as #460 says it's heavy to use small voxel size to calculate so I revert this

Description(required)

revert 414

Review Procedure(required)

launch psim

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

…owarefoundation#414)"

This reverts commit d29e0e1.

Signed-off-by: taikitanaka <ttatcoder@outlook.jp>
Signed-off-by: taikitanaka <ttatcoder@outlook.jp>
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #468 (9d0773c) into tier4/proposal (6ded065) will decrease coverage by 11.00%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           tier4/proposal    #468       +/-   ##
==================================================
- Coverage           11.00%   0.00%   -11.01%     
==================================================
  Files                 704      12      -692     
  Lines               49459     449    -49010     
  Branches             6647       0     -6647     
==================================================
- Hits                 5442       0     -5442     
+ Misses              39657     449    -39208     
+ Partials             4360       0     -4360     
Impacted Files Coverage Δ
simulator/dummy_perception_publisher/src/node.cpp 0.00% <ø> (ø)
...ude/scene_module/virtual_traffic_light/manager.hpp
...elevation_map_loader/elevation_map_loader_node.hpp
...cluster/lib/voxel_grid_based_euclidean_cluster.cpp
...src/outlier_filter/ring_outlier_filter_nodelet.cpp
system/velodyne_monitor/src/velodyne_monitor.cpp
...tion/traffic_light_classifier/utils/trt_common.hpp
...utoware_auto_common/test/test_bool_comparisons.cpp
...ner/src/scene_module/occlusion_spot/grid_utils.cpp
...de/lidar_apollo_instance_segmentation/detector.hpp
... and 683 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 405c0ca...9d0773c. Read the comment docs.

@taikitanaka3 taikitanaka3 enabled auto-merge (squash) March 2, 2022 12:53
yukkysaito
yukkysaito previously approved these changes Mar 3, 2022
@taikitanaka3 taikitanaka3 changed the base branch from tier4/proposal to main March 3, 2022 10:57
@taikitanaka3 taikitanaka3 dismissed yukkysaito’s stale review March 3, 2022 10:57

The base branch was changed.

@yukkysaito yukkysaito self-requested a review March 3, 2022 16:06
@taikitanaka3 taikitanaka3 merged commit 6f778c9 into autowarefoundation:main Mar 3, 2022
@taikitanaka3 taikitanaka3 deleted the 413-revert-dummy_perception-change-leaf-size branch April 13, 2022 09:54
tkimura4 referenced this pull request in tier4/autoware.universe Oct 24, 2022
…deceleration (#468)

fix(behavior_path_planner): fix request_length and maximum_deceleration

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
HansOersted pushed a commit to HansOersted/autoware.universe that referenced this pull request Mar 8, 2024
Update repos files

Co-authored-by: GitHub Actions <actions@example.com>
YamatoAndo pushed a commit to YamatoAndo/autoware.universe that referenced this pull request Aug 8, 2024
…tion#468)

* fix(behavior_path_planner): fix build error in Humble

* ci(pre-commit): autofix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants