Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ad_service_state_monitor): fix node names in comments #450

Merged
merged 2 commits into from
Feb 28, 2022
Merged

chore(ad_service_state_monitor): fix node names in comments #450

merged 2 commits into from
Feb 28, 2022

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Feb 28, 2022 •
edited by kenji-miyake
Loading

Related Issue(required)

Description(required)

fix typo Autoware -> AD Service

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@codecov
Copy link

codecov bot commented Feb 28, 2022 •
edited
Loading

Codecov Report

Merging #450 (2b3fe9a) into tier4/proposal (dbc8580) will decrease coverage by 10.99%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           tier4/proposal    #450       +/-   ##
==================================================
- Coverage           10.99%   0.00%   -11.00%     
==================================================
  Files                 705       7      -698     
  Lines               49460     406    -49054     
  Branches             6658       0     -6658     
==================================================
- Hits                 5436       0     -5436     
+ Misses              39663     406    -39257     
+ Partials             4361       0     -4361
Impacted Files Coverage Δ
...er/include/scene_module/occlusion_spot/manager.hpp
...ene_module/occlusion_spot/occlusion_spot_utils.hpp
..._planner/src/scene_module/occlusion_spot/debug.cpp
...ner/src/scene_module/occlusion_spot/grid_utils.cpp
...lanner/src/scene_module/occlusion_spot/manager.cpp
..._module/occlusion_spot/risk_predictive_braking.cpp
...ene_module/occlusion_spot/scene_occlusion_spot.cpp
...usion_spot/scene_occlusion_spot_in_public_road.cpp
...lisher/include/dummy_perception_publisher/node.hpp
...are_auto_geometry/include/geometry/convex_hull.hpp
... and 688 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4707dcb...2b3fe9a. Read the comment docs.

@kenji-miyake kenji-miyake changed the title chore(ad_service_state_monitor): fix typo chore(ad_service_state_monitor): fix node names in comments Feb 28, 2022
@kenji-miyake kenji-miyake enabled auto-merge (squash) February 28, 2022 07:21
@kenji-miyake kenji-miyake merged commit 4bef070 into tier4/proposal Feb 28, 2022
@kenji-miyake kenji-miyake deleted the h-ohta-patch-1 branch February 28, 2022 07:31
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Feb 28, 2022
Merged
mitsudome-r added a commit to mitsudome-r/autoware.universe that referenced this pull request Mar 1, 2022
@1222-takeshi @mitsudome-r
@wep21 @yukkysaito @esteve @jilaada @TakaHoribe @isamu-takagi @kmiya @tkimura4 @kenji-miyake @taikitanaka3 @KeisukeShima @yk-fujii @s-azumi @h-ohta @tier4-autoware-private-bot @g-ise @yukke42 @satoshi-ota @pre-commit-ci
feat: add perception launch package (autowarefoundation#176)
1587b68 
* release v0.4.0

* Nodelet tlr (autowarefoundation#56)

* temporary commit tlr_nodelet

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* compressed to compressed

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* Update traffic_light.launch

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* change image_transport to relay

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* decompress as rgb8

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* removed ROS1 package

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "removed ROS1 package"

This reverts commit 976754a13aff34af749503d187c3851adbd3e73b.

* add COLCON_IGNORE file to all ROS1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* rename *.launch files to *.launch.xml

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* [ROS2 Porting] perception_launch (#6)

* Initial port to ROS 2

* Port to ROS 2

* Added dependencies

* fix perception_launch

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Use arg instead of let

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* [perception_launch] fix perception_launch (autowarefoundation#34)

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* perception_launch: Fix lidar based detection launch (autowarefoundation#42)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* ROS2 Linting: perception_launch (autowarefoundation#36)

* Add linters and missing package dependencies

* Alphabetise packages

* perception_launch: Traffic light composable nodes (autowarefoundation#43)

* perception_launch: Traffic light composable nodes

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix arg

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [perception launch]: Remove unused import

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix dependency temporarily for v0.8.0 update. (autowarefoundation#60)

* Fix build_depends.repos temporarily

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Remove deprecated packages

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Ros2 v0.8.0 perception launch (autowarefoundation#56)

* restore file names

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* update camera lidar fusion arch (autowarefoundation#122)

* Update yolo launch (autowarefoundation#155)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Revert "restore file names"

This reverts commit 7b50ca1b0067cc29eed73b992dd2bbadc538f4f9.

* fix name

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix launch arg

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix dependency

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* cosmetic change (autowarefoundation#138)

* cosmetic change

* add image topic

* fix bug

* rename topic names according to ros2 topic name rules

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* [perception_launch] add object_merger as exec_depend

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* [perception launch]: Add missing dependecies for traffic light recognition

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [perception launch]: Fix attributes in arg tag

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [perceptioon_launch] update roi_visualization launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [perception_launch]: Fix camera topic name

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [perception_launch]: Fix camera default topic in fusion launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add depend tag for image_transport_plugin (autowarefoundation#95)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix typo in perception launch files (autowarefoundation#93)

* add use_sim-time option (autowarefoundation#99)

* Format launch files (autowarefoundation#178)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Sync public repo (autowarefoundation#185)

* add tier4 usbcam (autowarefoundation#104)

* add tier4 usbcam

* change version

* tier4/ros2

* Ros2 vehicle info param server (autowarefoundation#96)

* add vehicle info param server

* delete vehicle param file

Co-authored-by: taikitanaka <ttatcoder@outlook.jp>

* Ros2 fix topic name part2 (autowarefoundation#89)

* Fix topic name for traffic_light_classifier

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix topic name for traffic_light_visualization

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix topic name for traffic_light_ssd_fine_detector

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: taikitanaka <ttatcoder@outlook.jp>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>

* Fix incorrect remap (autowarefoundation#183)

* Fix incorrect remap

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Use set_remap

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Use set_parameter for use_sim_time (autowarefoundation#198)

* Use set_parameter for use_sim_time

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add default parameter for scenario simulator

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Feature/porting v0.9.1 master (autowarefoundation#202)

* add simulation arg (autowarefoundation#174)

* add simulation arg

* add comment

* change arg name

* add parameter use_empty_dynamic_object_publisher into perception.launch (autowarefoundation#176)

Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp>

Co-authored-by: Yusuke FUJII <yusuke.fujii@tier4.jp>
Co-authored-by: s-azumi <38061530+s-azumi@users.noreply.github.com>

* Format launch files (autowarefoundation#228)

* Format launch files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Format launch.py

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix lint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Put image decompressor into container (autowarefoundation#241)

* Put image decompressor into container

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix bug

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add traffic light map viz (autowarefoundation#149) (autowarefoundation#207)

* add traffic light map viz (autowarefoundation#149)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix launch tag

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add description for perception (autowarefoundation#334)

* add README.md and svg files (autowarefoundation#328)

* add md and svg

* fix typo

* fix typo

* fix word

* fix typo

* add lack of things

* Update README

* fix depending packages

* fix word

* add config directory to perception_launch  and data_association_matrix.param.yaml autowarefoundation#367

Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>

* Fix pre-commit (autowarefoundation#407)

* Fix pre-commit errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix package.xml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix: Modify arg in drawio graph for README (perception launch) (autowarefoundation#466)

Modified True/False and alignment (put to center) of use_empty_dynamic_object_publisher in drawio graph.

* lidar_detection: apollo instance segmentation -> centerpoint (autowarefoundation#225) (autowarefoundation#307)

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Feature/porting camera lidar fusion (autowarefoundation#316)

* Feature/camera lidar fusion (autowarefoundation#248)

* change camera lidar fusion node

* change default mode of object recognition

* change spilit range parameter from 10 to 30 (autowarefoundation#272)

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* add detection by tracker (autowarefoundation#418)

add detection by tracker

* Add option to select lidar detection model (autowarefoundation#450)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Change formatter to black (autowarefoundation#488)

* Update pre-commit settings

* Apply Black

* Replace ament_lint_common with autoware_lint_common

* Update build_depends.repos

* Fix build_depends

* Auto/fix launch (autowarefoundation#110)

* fix namespace

* remove dynamic_object_visualization

* fix rviz

* Update package.xml (autowarefoundation#111)

* remove unused depend/launcher (autowarefoundation#112)

* Auto/launcher ground segmentation (autowarefoundation#117)

* add base line launch

* add ground_segmentation launcher

* run pre-commit

* clean up

* fix coding style

* fix topic name

* fix yaml params

* fix loader name

* rename components

* improve implementation

* add feature remover (autowarefoundation#122)

* add feature remover (autowarefoundation#124)

* support x1 perception config (autowarefoundation#129)

* support x1 perception config

* remove product config

* update launch.py

* maintain some filters params in yaml file

* add function to create elevation map pipeline

* add param to yaml

* Update traffic light topic name (autowarefoundation#131)

* Update traffic light topic name

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Update traffic light topic name in perception

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix exec depend in perception launch (autowarefoundation#132)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* auto/fix occupancy grid map topic name (autowarefoundation#137)

* fix/rename segmentation namespace (autowarefoundation#139)

* fix namespace: rviz config

* fix namespace: planning stack

* rename segmentatino directory

* fix namespace: perception stack

* fix/move occupancy grid map outlier filter (autowarefoundation#143)

* fix package name

* add occupancy grid map launch

* update launcher

* rename filter package

* fix/add pointcloud_preprocessor depend (autowarefoundation#146)

* fix/add use_intra_process_comm option (autowarefoundation#148)

* feature/use common pointcloud container (autowarefoundation#147)

* add container argument

* load composable node to pointcloud_container

* fix autoware_launch

* enable multi-thread

* improve readability

* Add elevation map loader to ground seg launch (autowarefoundation#136)

* change elevation_map_parameters location (autowarefoundation#151)

* refactor ground segmentation launch (autowarefoundation#153)

* Fix/update obstacle segmentation namespace (autowarefoundation#154)

* update topic name

* update namespace

* feat: add default vehicle param

* fix: common_ground_filter for use default param

* ci(pre-commit): autofix

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Esteve Fernandez <esteve@apache.org>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: Jilada Eccleston <jilada.eccleston@tier4.jp>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Co-authored-by: taikitanaka <ttatcoder@outlook.jp>
Co-authored-by: Keisuke Shima <keisuke.shima@tier4.jp>
Co-authored-by: Yusuke FUJII <yusuke.fujii@tier4.jp>
Co-authored-by: s-azumi <38061530+s-azumi@users.noreply.github.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>
Co-authored-by: g-ise <53168213+g-ise@users.noreply.github.com>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
@wep21
Add option to select lidar detection model (autowarefoundation#450)
60d4372 
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
@wep21 @kenji-miyake
Add option to select lidar detection model (autowarefoundation#450)
aef5e4b 
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
tkimura4 referenced this pull request in tier4/autoware.universe Oct 24, 2022
@kosuke55
feat(behavior_path_planner): change pull_over_velocity (#450)
1ae4675 
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023
@ismetatabay
refactor(autoware_launch): add lidar models params (autowarefoundatio…
f69d476 
…n#450)

* init commit

Signed-off-by: ismetatabay <ismet@leodrive.ai>

* add centerpoint params

Signed-off-by: ismetatabay <ismet@leodrive.ai>

* remove dupplicated commits

Signed-off-by: ismetatabay <ismet@leodrive.ai>

---------

Signed-off-by: ismetatabay <ismet@leodrive.ai>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
@shmpwk
fix: ignore checking private markdown link (#450)
2fd4dce 
* fix: rm markdown-link-check

* fix: skip checking private markdown link

* fix: ignore local host link

* chore: typo
HansOersted pushed a commit to HansOersted/autoware.universe that referenced this pull request Mar 8, 2024
@tier4-autoware-private-bot
chore: update beta branch for beta/v2.3.0 (autowarefoundation#450)
61a4cd2 
Update repos files

Co-authored-by: GitHub Actions <actions@example.com>
YamatoAndo pushed a commit to YamatoAndo/autoware.universe that referenced this pull request Aug 8, 2024
@h-ohta @pre-commit-ci
fix(tier4_planning_rviz_plugin): fix build error in Humble (autowaref…
36358a2 
…oundation#450)

* fix(tier4_planning_rviz_plugin): fix build error in Humble

* ci(pre-commit): autofix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenji-miyake kenji-miyake kenji-miyake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-ohta @kenji-miyake