Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avoidance): add parameter to configurate avoidance return point #4467

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jul 31, 2023

Description

Add new parameter remain_buffer_distance in order to keep constant remaining distance between avoidance end point and path end point.

Please approve ⬇️ before this PR.
autowarefoundation/autoware_launch#493

simplescreenrecorder-2023-07-31_14.54.57.mp4

Tests performed

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 31, 2023
@satoshi-ota satoshi-ota enabled auto-merge (squash) July 31, 2023 22:59
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (bfe5314) 14.91% compared to head (3eb301c) 14.90%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4467      +/-   ##
==========================================
- Coverage   14.91%   14.90%   -0.01%     
==========================================
  Files        1517     1517              
  Lines      104701   104785      +84     
  Branches    31884    31938      +54     
==========================================
+ Hits        15619    15622       +3     
- Misses      72030    72107      +77     
- Partials    17052    17056       +4     
Flag Coverage Δ *Carryforward flag
differential 13.28% <0.00%> (?)
total 14.91% <ø> (+<0.01%) ⬆️ Carriedforward from bfe5314

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 11.76% <0.00%> (-0.03%) ⬇️
...ath_planner/src/scene_module/avoidance/manager.cpp 6.69% <0.00%> (-0.04%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit 2f282ed into autowarefoundation:main Aug 1, 2023
44 of 48 checks passed
@satoshi-ota satoshi-ota deleted the feat/avoidance-end-point branch August 1, 2023 06:24
felixf4xu pushed a commit to felixf4xu/autoware.universe that referenced this pull request Aug 2, 2023
…utowarefoundation#4467)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: Felix F Xu <felixfxu@gmail.com>
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 24, 2023
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 24, 2023
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 24, 2023
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 25, 2023
* feat(avoidance): add parameter to configurate avoidance return point (autowarefoundation#4467)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(utils): improve monotonic bound generation logic (autowarefoundation#4706)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): insert return dead line point (autowarefoundation#5029)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): exit if there is no avoidable object (autowarefoundation#5051)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants