Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection_occlusion): ignore occlusion behind parked vehicles on the attention lane #4466

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Jul 31, 2023

Description

Related links

https://tier4.atlassian.net/browse/RT1-3244
launcher PR: autowarefoundation/autoware_launch#492

Tests performed

Psim and experiment

Notes for reviewers

Interface changes

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…g lane

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 31, 2023
@soblin soblin marked this pull request as ready for review July 31, 2023 06:47
@soblin soblin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05% ⚠️

Comparison is base (8a82fa9) 14.91% compared to head (5178bc2) 14.86%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4466      +/-   ##
==========================================
- Coverage   14.91%   14.86%   -0.05%     
==========================================
  Files        1517     1517              
  Lines      104695   105046     +351     
  Branches    31880    32141     +261     
==========================================
  Hits        15619    15619              
- Misses      72024    72348     +324     
- Partials    17052    17079      +27     
Flag Coverage Δ *Carryforward flag
differential 7.19% <0.00%> (?)
total 14.91% <ø> (+<0.01%) ⬆️ Carriedforward from 8a82fa9

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...avior_velocity_intersection_module/src/manager.cpp 19.13% <0.00%> (-0.19%) ⬇️
...ity_intersection_module/src/scene_intersection.cpp 0.00% <0.00%> (ø)
...ity_intersection_module/src/scene_intersection.hpp 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 50a752b into autowarefoundation:main Aug 1, 2023
34 of 39 checks passed
@soblin soblin deleted the feat/ignore-parked-vehicle-behind-occlusion branch August 1, 2023 01:37
felixf4xu pushed a commit to felixf4xu/autoware.universe that referenced this pull request Aug 2, 2023
… on the attention lane (autowarefoundation#4466)

Signed-off-by: Felix F Xu <felixfxu@gmail.com>
soblin added a commit to tier4/autoware.universe that referenced this pull request Aug 8, 2023
1222-takeshi added a commit to tier4/autoware.universe that referenced this pull request Aug 14, 2023
feat(intersection_occlusion): ignore occlusion behind parked vehicles on the attention lane (autowarefoundation#4466)
soblin added a commit to tier4/autoware.universe that referenced this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants