Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_autoware_utils): add calcSignedArcLength from pose to pose #421

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Feb 19, 2022

Related Issue(required)

#265

Description(required)

add pose to pose arc length(no behavior change)

Review Procedure(required)

see build pass
below is different from arclength from pose to point
image

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: taikitanaka <ttatcoder@outlook.jp>
Signed-off-by: taikitanaka <ttatcoder@outlook.jp>
@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #421 (e00ffdb) into tier4/proposal (0af7a42) will decrease coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           tier4/proposal    #421      +/-   ##
=================================================
- Coverage           10.10%   9.57%   -0.53%     
=================================================
  Files                 705     460     -245     
  Lines               49295   36400   -12895     
  Branches             6265    4829    -1436     
=================================================
- Hits                 4980    3487    -1493     
+ Misses              40248   29837   -10411     
+ Partials             4067    3076     -991     
Impacted Files Coverage Δ
...ude/tier4_autoware_utils/trajectory/trajectory.hpp 92.30% <ø> (ø)
...vehicle_model/sim_model_delay_steer_acc_geared.cpp 0.00% <0.00%> (ø)
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 0.00% <0.00%> (ø)
...selector/external_velocity_limit_selector_node.hpp
control/shift_decider/src/shift_decider.cpp
...er4_state_rviz_plugin/src/autoware_state_panel.cpp
...ose_button_panel/src/initial_pose_button_panel.cpp
common/tier4_api_utils/test/test.cpp
...mon/autoware_point_types/test/test_point_types.cpp
...r_apollo_instance_segmentation/src/feature_map.cpp
... and 238 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0af7a42...e00ffdb. Read the comment docs.

@takayuki5168
Copy link
Contributor

LGTM
If you still wanna merge this PR, please get :saitokantoku:'s approval.

@taikitanaka3 taikitanaka3 marked this pull request as draft February 21, 2022 10:35
@stale
Copy link

stale bot commented Apr 22, 2022

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Apr 22, 2022
@kenji-miyake kenji-miyake deleted the branch autowarefoundation:tier4/proposal May 2, 2022 11:00
@kenji-miyake
Copy link
Contributor

@taikitanaka3 Please resubmit this to main if you still need this PR. 🙏

@kenji-miyake kenji-miyake deleted the 265-add-calc-signed-arclength-from-pose-to-pose branch July 7, 2022 04:03
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
tkimura4 referenced this pull request in tier4/autoware.universe Oct 24, 2022
…421)

* refactor(obstacle_avoidance_planner): use max_steer_angle in common

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix runtime error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request May 12, 2023
…undation#3660) (autowarefoundation#421)

* fix(behavior_path_planner): add drivable area information



* fix(behavior_path_planner): fix typo



* fix(behavior_path_planner): fix cmake



* fix(behavior_path_planner): cosmetic change



---------

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023
…abort can be performed (autowarefoundation#421)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants