-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(goal_planner): support following lanes over the next lane #4167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosuke55
requested review from
rej55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
July 4, 2023 12:55
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Jul 4, 2023
kosuke55
changed the title
Fix/pull over to extended lanes
fix(goal_planner): support following lanes over the next lane
Jul 4, 2023
kosuke55
force-pushed
the
fix/pull_over_to_extended_lanes
branch
from
July 4, 2023 12:57
4b75af0
to
66f98d8
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4167 +/- ##
=======================================
Coverage 14.30% 14.30%
=======================================
Files 1571 1571
Lines 108348 108376 +28
Branches 31362 31371 +9
=======================================
+ Hits 15497 15503 +6
- Misses 76001 76021 +20
- Partials 16850 16852 +2
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
takayuki5168
approved these changes
Jul 4, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
force-pushed
the
fix/pull_over_to_extended_lanes
branch
from
July 4, 2023 14:35
66f98d8
to
b291167
Compare
1222-takeshi
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 7, 2023
…refoundation#4167) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
7 tasks
1222-takeshi
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 10, 2023
* fix(start_planner): fix path cut by U turn goal (autowarefoundation#4109) * fix(start_planner): fix path cut by U turn goal Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * cut path Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * feat(behavior_path_planner): add getExtendedCurrentLanes with length args (autowarefoundation#4166) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix(goal_planner): support following lanes over the next lane (autowarefoundation#4167) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * feat(behavior_path_planner): add getCurrentLanes with length args (autowarefoundation#4108) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
kyoichi-sugahara
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 28, 2023
…refoundation#4167) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Can not plan pull over path following lanes over next lanes because use only one next lane of current lanes for reference path.
In this PR extend current lanes by goal search length
goal_planner_goal_search-2023-07-04_20.31.25.mp4
Related links
need #4166
Tests performed
tie4_interl_sceneario_test
https://evaluation.tier4.jp/evaluation/reports/8d967fb3-de5c-5844-9a08-865792cc1c79?project_id=prd_jt
1575/1579
base line 1572/1579(2023/07/03)
psim
goal_planner_goal_search-2023-07-04_21.25.56.mp4
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.