Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goal_planner): support following lanes over the next lane #4167

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jul 4, 2023

Description

Can not plan pull over path following lanes over next lanes because use only one next lane of current lanes for reference path.
In this PR extend current lanes by goal search length

goal_planner_goal_search-2023-07-04_20.31.25.mp4

Related links

need #4166

Tests performed

tie4_interl_sceneario_test
https://evaluation.tier4.jp/evaluation/reports/8d967fb3-de5c-5844-9a08-865792cc1c79?project_id=prd_jt
1575/1579

base line 1572/1579(2023/07/03)

psim

goal_planner_goal_search-2023-07-04_21.25.56.mp4

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 4, 2023
@kosuke55 kosuke55 changed the title Fix/pull over to extended lanes fix(goal_planner): support following lanes over the next lane Jul 4, 2023
@kosuke55 kosuke55 force-pushed the fix/pull_over_to_extended_lanes branch from 4b75af0 to 66f98d8 Compare July 4, 2023 12:57
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 15.55% and no project coverage change.

Comparison is base (01bf2c6) 14.30% compared to head (b291167) 14.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4167   +/-   ##
=======================================
  Coverage   14.30%   14.30%           
=======================================
  Files        1571     1571           
  Lines      108348   108376   +28     
  Branches    31362    31371    +9     
=======================================
+ Hits        15497    15503    +6     
- Misses      76001    76021   +20     
- Partials    16850    16852    +2     
Flag Coverage Δ *Carryforward flag
differential 13.49% <15.55%> (?)
total 14.30% <ø> (+<0.01%) ⬆️ Carriedforward from 01bf2c6

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ject_tracker/src/tracker/model/bicycle_tracker.cpp 0.00% <ø> (ø)
..._tracker/src/tracker/model/big_vehicle_tracker.cpp 0.00% <ø> (ø)
...acker/src/tracker/model/normal_vehicle_tracker.cpp 0.00% <ø> (ø)
...ic_parallel_parking/geometric_parallel_parking.hpp 20.00% <ø> (ø)
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
.../scene_module/goal_planner/goal_planner_module.cpp 5.96% <0.00%> (-0.03%) ⬇️
...cene_module/start_planner/start_planner_module.cpp 4.23% <ø> (ø)
...ic_parallel_parking/geometric_parallel_parking.cpp 0.00% <0.00%> (ø)
...ner/src/utils/goal_planner/geometric_pull_over.cpp 21.73% <0.00%> (ø)
...h_planner/src/utils/goal_planner/goal_searcher.cpp 2.27% <0.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the fix/pull_over_to_extended_lanes branch from 66f98d8 to b291167 Compare July 4, 2023 14:35
@1222-takeshi 1222-takeshi merged commit 3b0671a into main Jul 7, 2023
23 of 24 checks passed
@1222-takeshi 1222-takeshi deleted the fix/pull_over_to_extended_lanes branch July 7, 2023 08:09
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Jul 7, 2023
1222-takeshi added a commit to tier4/autoware.universe that referenced this pull request Jul 10, 2023
* fix(start_planner): fix path cut by U turn goal (autowarefoundation#4109)

* fix(start_planner): fix path cut by U turn goal

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* cut path

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat(behavior_path_planner): add getExtendedCurrentLanes with length args (autowarefoundation#4166)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix(goal_planner): support following lanes over the next lane (autowarefoundation#4167)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat(behavior_path_planner): add getCurrentLanes with length args (autowarefoundation#4108)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants