New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(behavior_path_planner): remove redundant process #4077

Merged

rej55 merged 1 commit into autowarefoundation:main from rej55:feat/remove_redundant_process

Jun 26, 2023

Merged

feat(behavior_path_planner): remove redundant process #4077

feat(behavior_path_planner): remove redundant process

This check has been archived and is scheduled for deletion. Learn more about checks retention

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jun 26, 2023 in 45s

CodeScene PR Check

❌ Quality Gates: FAILED

Declining Code Health: 1 findings(s) 🚩
Improving Code Health: 0 findings(s) ✅
Affected Hotspots: 1 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Negative Code Health Impact (highest to lowest):

Complex Method normal.cpp: NormalLaneChange::getLaneChangePaths 🔥

Annotations

Check warning on line 734 in planning/behavior_path_planner/src/scene_module/lane_change/normal.cpp

codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

NormalLaneChange::getLaneChangePaths increases in cyclomatic complexity from 26 to 27, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

View more details on CodeScene Delta Analysis