Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): remove redundant process #4077

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented Jun 26, 2023

Description

Before this change, redundant safety check is included in lane change module.
In this PR, I remove redundant safety check.

Related links

Tests performed

Tested in planning simulator.

TIER IV INTERNAL TEST

1 cycle elapsed time (3 obstacles)

  • Before 75 ~ 90 ms
  • After 20 ~ 35 ms

Notes for reviewers

Interface changes

Nothing.

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 26, 2023
@rej55 rej55 marked this pull request as ready for review June 26, 2023 06:04
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 28.57% and no project coverage change.

Comparison is base (a3c6ea2) 14.36% compared to head (fc6ec33) 14.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4077   +/-   ##
=======================================
  Coverage   14.36%   14.36%           
=======================================
  Files        1566     1566           
  Lines      107727   107730    +3     
  Branches    31176    31175    -1     
=======================================
+ Hits        15478    15480    +2     
- Misses      75421    75422    +1     
  Partials    16828    16828           
Flag Coverage Δ *Carryforward flag
differential 13.64% <28.57%> (?)
total 14.36% <ø> (-0.01%) ⬇️ Carriedforward from a3c6ea2

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...th_planner/scene_module/lane_change/base_class.hpp 16.27% <ø> (-0.39%) ⬇️
...r_path_planner/scene_module/lane_change/normal.hpp 0.00% <ø> (ø)
...path_planner/src/marker_util/lane_change/debug.cpp 0.00% <0.00%> (ø)
...th_planner/src/scene_module/lane_change/normal.cpp 4.89% <33.33%> (+0.49%) ⬆️
...planner/src/scene_module/lane_change/interface.cpp 5.36% <50.00%> (-0.19%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rej55 rej55 merged commit 80d5930 into autowarefoundation:main Jun 26, 2023
24 of 27 checks passed
@rej55 rej55 deleted the feat/remove_redundant_process branch June 26, 2023 08:14
rej55 added a commit to tier4/autoware.universe that referenced this pull request Jun 26, 2023
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants