Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): print avoidance and lane change debug mes… #4058

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

Description

Fix avoidance and lane change debug message not printing

Tests performed

Screenshot from 2023-06-23 14-26-21

Check via PSIM.

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…sage

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 23, 2023
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@zulfaqar-azmi-t4
Copy link
Contributor Author

Thank you Ota-san!

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch coverage: 10.00% and project coverage change: +0.29 🎉

Comparison is base (3b162aa) 14.31% compared to head (6eba14c) 14.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4058      +/-   ##
==========================================
+ Coverage   14.31%   14.60%   +0.29%     
==========================================
  Files        1557     1570      +13     
  Lines      106900   107740     +840     
  Branches    30777    31291     +514     
==========================================
+ Hits        15302    15740     +438     
- Misses      75028    75033       +5     
- Partials    16570    16967     +397     
Flag Coverage Δ *Carryforward flag
differential 13.61% <10.00%> (?)
total 14.31% <ø> (+<0.01%) ⬆️ Carriedforward from 3b162aa

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...id_map/laserscan_based_occupancy_grid_map_node.hpp 0.00% <ø> (ø)
...occupancy_grid_map_binary_bayes_filter_updater.hpp ∅ <ø> (∅)
...e/updater/occupancy_grid_map_updater_interface.hpp 0.00% <ø> (ø)
...id_map/laserscan_based_occupancy_grid_map_node.cpp 0.00% <ø> (ø)
...d_map/pointcloud_based_occupancy_grid_map_node.cpp 0.00% <ø> (ø)
...occupancy_grid_map_binary_bayes_filter_updater.cpp 0.00% <ø> (ø)
.../include/behavior_path_planner/planner_manager.hpp 18.86% <ø> (+18.86%) ⬆️
...or_path_planner/src/behavior_path_planner_node.cpp 17.67% <0.00%> (-0.66%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 13.16% <0.00%> (+9.02%) ⬆️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 5.81% <0.00%> (+3.08%) ⬆️
... and 1 more

... and 29 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 7c77bbd into autowarefoundation:main Jun 23, 2023
18 of 21 checks passed
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the fix-debug-message-not-printing branch June 23, 2023 07:37
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Jun 26, 2023
autowarefoundation#4058)

fix(behavior_path_planner): print avoidance and lane change debug message

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Jun 26, 2023
…sage (autowarefoundation#4058) (#621)

fix(behavior_path_planner): print avoidance and lane change debug mes… (autowarefoundation#4058)

fix(behavior_path_planner): print avoidance and lane change debug message

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants