Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_planner): consider previous module's turn signal #3637

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented May 8, 2023

Description

Consider previous module turn signal info.

Tests performed

Effects on system behavior

Improve turn signal behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 8, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the feat/consider-previous-module-signal-goal-planner branch from 059f173 to be134fa Compare May 8, 2023 23:32
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage: 18.57% and project coverage change: -0.01 ⚠️

Comparison is base (9693e36) 13.82% compared to head (be134fa) 13.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3637      +/-   ##
==========================================
- Coverage   13.82%   13.81%   -0.01%     
==========================================
  Files        1395     1395              
  Lines       98036    98089      +53     
  Branches    29147    29157      +10     
==========================================
+ Hits        13553    13555       +2     
- Misses      69826    69878      +52     
+ Partials    14657    14656       -1     
Flag Coverage Δ *Carryforward flag
differential 12.79% <18.57%> (?)
total 13.81% <ø> (-0.01%) ⬇️ Carriedforward from 9693e36

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../scene_module/goal_planner/goal_planner_module.cpp 5.93% <0.00%> (-0.06%) ⬇️
.../behavior_path_planner/src/turn_signal_decider.cpp 40.89% <5.88%> (-9.85%) ⬇️
...or_path_planner/src/behavior_path_planner_node.cpp 19.75% <66.66%> (+0.12%) ⬆️
...ner/include/behavior_path_planner/data_manager.hpp 37.50% <100.00%> (ø)
...lude/behavior_path_planner/turn_signal_decider.hpp 85.71% <100.00%> (+10.71%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota marked this pull request as ready for review May 9, 2023 04:00
@satoshi-ota satoshi-ota merged commit c638482 into autowarefoundation:main May 9, 2023
@satoshi-ota satoshi-ota deleted the feat/consider-previous-module-signal-goal-planner branch May 9, 2023 04:04
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants