Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: proper eigen deps and include #3615

Merged
merged 2 commits into from
May 3, 2023

Conversation

VRichardJP
Copy link
Contributor

@VRichardJP VRichardJP commented May 3, 2023

Description

As mentioned here, including eigen headers with #include <eigen3/Eigen/*> is not "correct". For example, if someone downloads and
installs eigen library from source manually, <depend>eigen</depend> and find_package(Eigen3) will work fine but the header may not be found, or the system eigen library header will be used instead if installed on the system (mixing Eigen version within the same compilation unit is most likely UB).

This PR replaces all #include <eigen3/Eigen/XXX> and #include "eigen3/Eigen/XXX" by the appropriate equivalent. Eigen dependency is added when necessary.

Tests performed

If it compiles, it should be Ok

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>
@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels May 3, 2023
@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) labels May 3, 2023
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b173491) 13.72% compared to head (ed3745e) 13.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3615   +/-   ##
=======================================
  Coverage   13.72%   13.73%           
=======================================
  Files        1397     1397           
  Lines       98263    98263           
  Branches    29238    29238           
=======================================
+ Hits        13490    13493    +3     
+ Misses      70233    70232    -1     
+ Partials    14540    14538    -2     
Flag Coverage Δ *Carryforward flag
differential 16.22% <ø> (?)
total 13.72% <ø> (ø) Carriedforward from b173491

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nterface/include/osqp_interface/osqp_interface.hpp 0.00% <ø> (ø)
common/osqp_interface/src/csc_matrix_conv.cpp 66.03% <ø> (ø)
...ommon/osqp_interface/test/test_csc_matrix_conv.cpp 9.70% <ø> (ø)
common/osqp_interface/test/test_osqp_interface.cpp 15.00% <ø> (ø)
...rviz_plugin/src/pose_history_footprint/display.cpp 0.00% <ø> (ø)
...planning_rviz_plugin/include/path/display_base.hpp 0.00% <ø> (ø)
...ce_analysis/control_performance_analysis_utils.hpp 0.00% <ø> (ø)
...pc_lateral_controller/qp_solver/qp_solver_osqp.hpp 0.00% <ø> (ø)
...l_controller/qp_solver/qp_solver_unconstr_fast.hpp 100.00% <ø> (ø)
...r/vehicle_model/vehicle_model_bicycle_dynamics.hpp 100.00% <ø> (ø)
... and 26 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kenji-miyake kenji-miyake merged commit 6920254 into autowarefoundation:main May 3, 2023
@VRichardJP VRichardJP deleted the fix_eigen branch May 3, 2023 23:51
@VRichardJP VRichardJP mentioned this pull request May 4, 2023
3 tasks
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
* build: proper eigen deps and include

Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants