refactor(behavior_path_planner): remove unnecessary modifyPathForSmoothGoalConnection

[kosuke55]

Description

moved modifyPathForSmoothGoalConnection to goal_planner in #3454, so behavior_path_planner_node's one is not used now.

Related links

#3454

Tests performed

build

Notes for reviewers

Interface changes

no

Effects on system behavior

no

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Patch coverage: 38.00% and project coverage change: +0.01 🎉

Comparison is base (d99718d) 14.10% compared to head (6d8a570) 14.11%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3602      +/-   ##
==========================================
+ Coverage   14.10%   14.11%   +0.01%     
==========================================
  Files        1397     1397              
  Lines       98212    98250      +38     
  Branches    29209    29233      +24     
==========================================
+ Hits        13852    13872      +20     
+ Misses      69603    69602       -1     
- Partials    14757    14776      +19     

Flag	Coverage Δ		*Carryforward flag
differential	12.34% <38.00%> (?)
total	14.10% <ø> (+<0.01%)	⬆️	Carriedforward from d99718d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...de/behavior_path_planner/behavior_tree_manager.hpp	0.00% <ø> (ø)
...ner/include/behavior_path_planner/data_manager.hpp	43.75% <ø> (ø)
.../include/behavior_path_planner/planner_manager.hpp	0.00% <ø> (ø)
...nner/include/behavior_path_planner/utils/utils.hpp	45.45% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp	20.20% <0.00%> (+0.28%)	⬆️
...ehavior_path_planner/src/behavior_tree_manager.cpp	56.56% <38.70%> (-6.67%)	⬇️
planning/behavior_path_planner/src/utils/utils.cpp	18.42% <38.88%> (+0.33%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.