-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_path_planner): fix goal planner backward parking #3601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
requested review from
rej55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901,
zulfaqar-azmi-t4 and
a team
as code owners
May 1, 2023 13:27
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
May 1, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3601 +/- ##
==========================================
+ Coverage 14.10% 14.11% +0.01%
==========================================
Files 1397 1397
Lines 98212 98264 +52
Branches 29209 29238 +29
==========================================
+ Hits 13852 13873 +21
- Misses 69603 69614 +11
- Partials 14757 14777 +20
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
takayuki5168
approved these changes
May 2, 2023
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
May 2, 2023
…refoundation#3601) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Merged
7 tasks
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
May 3, 2023
…refoundation#3601) (#407) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Mingyu1991
pushed a commit
to Mingyu1991/autoware.universe
that referenced
this pull request
Jun 26, 2023
…refoundation#3601) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the bug that
goal_planner
canceled when backward parking.This bug was caused by #3541
Screencast.from.2023.04.27.14.51.24.webm
Related links
tier4 internal slack
tier4 internal ticket
Tests performed
psim
backward_parking-2023-05-01_22.12.57.mp4
backward_parking-2023-05-01_22.15.56.mp4
Notes for reviewers
Interface changes
no
Effects on system behavior
can execute backward pull over
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.