Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix goal planner backward parking #3601

Merged
merged 1 commit into from
May 2, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented May 1, 2023

Description

Fix the bug that goal_planner canceled when backward parking.
This bug was caused by #3541

Screencast.from.2023.04.27.14.51.24.webm

Related links

tier4 internal slack
tier4 internal ticket

Tests performed

psim

  • backward pull over can be done
backward_parking-2023-05-01_22.12.57.mp4
  • the goal can be put before the ego in the previous lane
  • can not put in the same lane (this is current planning limitation not just for goal_planner)
backward_parking-2023-05-01_22.15.56.mp4

Notes for reviewers

Interface changes

no

Effects on system behavior

can execute backward pull over

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 1, 2023
@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Patch coverage: 37.73% and project coverage change: +0.01 🎉

Comparison is base (d99718d) 14.10% compared to head (172f6eb) 14.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3601      +/-   ##
==========================================
+ Coverage   14.10%   14.11%   +0.01%     
==========================================
  Files        1397     1397              
  Lines       98212    98264      +52     
  Branches    29209    29238      +29     
==========================================
+ Hits        13852    13873      +21     
- Misses      69603    69614      +11     
- Partials    14757    14777      +20     
Flag Coverage Δ *Carryforward flag
differential 12.33% <37.73%> (?)
total 14.10% <ø> (+<0.01%) ⬆️ Carriedforward from d99718d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...de/behavior_path_planner/behavior_tree_manager.hpp 0.00% <ø> (ø)
...ner/include/behavior_path_planner/data_manager.hpp 43.75% <ø> (ø)
.../include/behavior_path_planner/planner_manager.hpp 0.00% <ø> (ø)
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 19.89% <0.00%> (-0.03%) ⬇️
.../scene_module/goal_planner/goal_planner_module.cpp 14.88% <33.33%> (+0.10%) ⬆️
...ehavior_path_planner/src/behavior_tree_manager.cpp 56.56% <38.70%> (-6.67%) ⬇️
planning/behavior_path_planner/src/utils/utils.cpp 18.42% <38.88%> (+0.33%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit 8b2da4b into main May 2, 2023
@kosuke55 kosuke55 deleted the fix/backward_pull_over branch May 2, 2023 03:28
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request May 2, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request May 3, 2023
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
…refoundation#3601)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants