Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rviz_plugin): fx traffic light and velocity factor rviz plugin #3598

Merged
merged 1 commit into from
May 8, 2023

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented May 1, 2023

Description

resolve #2923

fix panel view of table widgets

Tests performed

by psim

image

Add velocity and steering factor panel and traffic light publish panel

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label May 1, 2023
@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (b28d792) 11.52% compared to head (eab40d5) 11.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3598      +/-   ##
==========================================
- Coverage   11.52%   11.51%   -0.02%     
==========================================
  Files        1314     1314              
  Lines       92794    92948     +154     
  Branches    24997    24997              
==========================================
  Hits        10699    10699              
- Misses      70853    71007     +154     
  Partials    11242    11242              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.52% <ø> (ø) Carriedforward from b28d792

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...viz_plugin/src/velocity_steering_factors_panel.cpp 0.00% <0.00%> (ø)
...ht_rviz_plugin/src/traffic_light_publish_panel.cpp 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taikitanaka3
Copy link
Contributor Author

@satoshi-ota @h-ohta
can you approve this PR if this is OK?

@taikitanaka3
Copy link
Contributor Author

@satoshi-ota @h-ohta
kindly ping.

@taikitanaka3 taikitanaka3 merged commit a8cc29e into autowarefoundation:main May 8, 2023
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request May 9, 2023
…utowarefoundation#3598)

fix(rviz_plugin); fx traffic light and velocity factor rviz plugin
shmpwk pushed a commit that referenced this pull request May 9, 2023
…3598)

fix(rviz_plugin); fx traffic light and velocity factor rviz plugin
@taikitanaka3 taikitanaka3 deleted the fix/rviz_plugin branch May 10, 2023 03:28
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
…utowarefoundation#3598)

fix(rviz_plugin); fx traffic light and velocity factor rviz plugin

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table looks buggy in Rviz plugins
4 participants