Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior): add interface in order to publish marker that is always shown in rviz #3580

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Apr 28, 2023

Description

show module's important markers as default.
add anothre publisher.

(I'm working on implementation so that avoidance module outputs info markers.)

Tests performed

Psim

rviz_screenshot_2023_04_28-23_25_20

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 28, 2023
@satoshi-ota satoshi-ota changed the title feat(behavior): output important marker feat(behavior): add interface to publish marker that is always shown in rviz Apr 28, 2023
@satoshi-ota satoshi-ota changed the title feat(behavior): add interface to publish marker that is always shown in rviz feat(behavior): add interface in order to publish marker that is always shown in rviz Apr 28, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 3.42% and project coverage change: -0.02 ⚠️

Comparison is base (7bd2b78) 14.11% compared to head (94e8403) 14.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3580      +/-   ##
==========================================
- Coverage   14.11%   14.09%   -0.02%     
==========================================
  Files        1394     1396       +2     
  Lines       97800    97975     +175     
  Branches    28981    29079      +98     
==========================================
+ Hits        13804    13810       +6     
- Misses      69347    69500     +153     
- Partials    14649    14665      +16     
Flag Coverage Δ *Carryforward flag
differential 15.42% <3.42%> (?)
total 14.11% <ø> (ø) Carriedforward from 7bd2b78

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ner/include/behavior_path_planner/data_manager.hpp 46.66% <ø> (ø)
.../include/behavior_path_planner/planner_manager.hpp 0.00% <ø> (ø)
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp 0.00% <0.00%> (ø)
...ehavior_path_planner/src/behavior_tree_manager.cpp 63.23% <ø> (ø)
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% <0.00%> (ø)
...test/test_behavior_path_planner_node_interface.cpp 27.90% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 19.94% <26.31%> (+0.15%) ⬆️
...th_planner/scene_module/scene_module_interface.hpp 34.09% <33.33%> (-0.02%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@satoshi-ota satoshi-ota merged commit ff7c808 into autowarefoundation:main May 2, 2023
@satoshi-ota satoshi-ota deleted the feat/output-info-markers branch May 2, 2023 23:34
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request May 5, 2023
…ys shown in rviz (autowarefoundation#3580)

feat(behavior): output important marker

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request May 5, 2023
…ys shown in rviz (autowarefoundation#3580)

feat(behavior): output important marker

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request May 5, 2023
…ys shown in rviz (autowarefoundation#3580)

feat(behavior): output important marker

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Jun 20, 2023
…ys shown in rviz (autowarefoundation#3580)

feat(behavior): output important marker

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
…ys shown in rviz (autowarefoundation#3580)

feat(behavior): output important marker

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants