Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radar_fusion_to_detected_object): fix input from TrackedObjects to DetectedObjects #3459

Merged
merged 3 commits into from
May 10, 2023

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Apr 19, 2023

Description

Change from TrackedObjects to DetectedObjects for the input of radar_fusion_to_detected_object, according to #3450.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
@scepter914 scepter914 requested a review from YoshiRi April 19, 2023 04:41
@scepter914 scepter914 requested review from miursh and a team as code owners April 19, 2023 04:41
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Apr 19, 2023
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.76 ⚠️

Comparison is base (8f71738) 14.09% compared to head (5fc4eca) 12.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3459      +/-   ##
==========================================
- Coverage   14.09%   12.34%   -1.76%     
==========================================
  Files        1396     1381      -15     
  Lines       97972    96555    -1417     
  Branches    29077    27994    -1083     
==========================================
- Hits        13808    11918    -1890     
- Misses      69500    72008    +2508     
+ Partials    14664    12629    -2035     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 12.34% <ø> (-1.76%) ⬇️ Carriedforward from 58cd9e6

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...de/radar_object_fusion_to_detected_object_node.cpp 0.00% <ø> (ø)

... and 242 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scepter914 scepter914 merged commit e4fefd4 into autowarefoundation:main May 10, 2023
@scepter914 scepter914 deleted the fix/radar_fusion_input branch May 10, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants