Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radar_converter_outputs): add DetectedObjects output #3450

Merged

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Apr 18, 2023

Description

Add DetectedObjects output into radar_converter_outputs to custom radar faraway detection pipeline.
After this PR is merged, I'll change the input interface of radar_fusion_to_detected_object.

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
…utoware.universe into fix/radar_converter_outputs
@scepter914 scepter914 requested a review from YoshiRi April 18, 2023 08:20
@scepter914 scepter914 requested review from miursh and a team as code owners April 18, 2023 08:20
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.08 ⚠️

Comparison is base (0e1e963) 14.52% compared to head (9d03b00) 12.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3450      +/-   ##
==========================================
- Coverage   14.52%   12.45%   -2.08%     
==========================================
  Files        1287     1381      +94     
  Lines       91309    95545    +4236     
  Branches    28616    27263    -1353     
==========================================
- Hits        13260    11896    -1364     
- Misses      63793    71062    +7269     
+ Partials    14256    12587    -1669     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 12.45% <ø> (-2.07%) ⬇️ Carriedforward from e2cf875

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...based_prediction/src/map_based_prediction_node.cpp 0.00% <ø> (ø)
...sgs_converter/radar_tracks_msgs_converter_node.hpp 0.00% <ø> (ø)
...onverter_node/radar_tracks_msgs_converter_node.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <ø> (-3.44%) ⬇️

... and 267 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scepter914 scepter914 merged commit 279b64a into autowarefoundation:main Apr 28, 2023
@scepter914 scepter914 deleted the fix/radar_converter_outputs branch April 28, 2023 20:28
@miursh
Copy link
Contributor

miursh commented May 9, 2023

@scepter914 Sorry I missed confirming the influence.
Isn't change in radar_based_detection.launch.xml necessary as well?

@scepter914
Copy link
Contributor Author

@miursh
Yes, it is necessary.
I'll fix launchers on new PR.

Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
…ndation#3450)

* fix(radar_tracks_msgs_converter_node): add DetectedObjects output

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix typo

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix(radar_tracks_msgs_converter_node): add DetectedObjects output

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix typo

Signed-off-by: scepter914 <scepter914@gmail.com>

* update launcher

Signed-off-by: scepter914 <scepter914@gmail.com>

---------

Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants