Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): use snake case for debug marker #3342

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Apr 10, 2023

Description

Related PR: autowarefoundation/autoware_launch#289

Fix debug topic name and use snake_case. (e.g. ~/debug/pullover -> ~/debug/pull_over)

Tests performed

rviz_screenshot_2023_04_10-20_41_10

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 10, 2023
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (4a84fb8) 12.34% compared to head (9fa2795) 12.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3342      +/-   ##
==========================================
- Coverage   12.34%   12.34%   -0.01%     
==========================================
  Files        1381     1381              
  Lines       96684    96685       +1     
  Branches    27977    27977              
==========================================
  Hits        11931    11931              
  Misses      72087    72087              
- Partials    12666    12667       +1     
Flag Coverage Δ *Carryforward flag
differential 5.27% <0.00%> (?)
total 12.34% <ø> (+<0.01%) ⬆️ Carriedforward from 4a84fb8

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...th_planner/scene_module/scene_module_interface.hpp 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
LGTM

@satoshi-ota satoshi-ota merged commit 93e040a into autowarefoundation:main Apr 10, 2023
@satoshi-ota satoshi-ota deleted the fix/snake-case branch April 10, 2023 13:13
purewater0901 pushed a commit that referenced this pull request Apr 11, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants