Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_simulator_launch): fix launch package name #3340

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Apr 10, 2023

Description

It has to update tier4_simulator_launch for this PR #3058.

Tests performed

I confirmed simualtor works well in my local env.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@satoshi-ota satoshi-ota marked this pull request as ready for review April 10, 2023 07:59
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satoshi-ota
If you can tolerate the visual complication, it would be helpful if you could write the following as the #3058 changes.

    <include file="$(find-pkg-share tier4_perception_launch)/launch/occupancy_grid_map/probabilistic_occupancy_grid_map.launch.xml">
      <arg name="input_obstacle_pointcloud" value="true"/>
      <arg name="input_obstacle_and_raw_pointcloud" value="false"/>
      <arg name="input/obstacle_pointcloud" value="/perception/obstacle_segmentation/pointcloud"/>
      <arg name="output" value="/perception/occupancy_grid_map/map"/>
      <arg name="method" value="laserscan_based_occupancy_grid_map"/>
      <arg name="map_origin" value="base_link"/>
      <arg name="scan_origin" value="base_link"/>
    </include>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota enabled auto-merge (squash) April 10, 2023 08:28
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Apr 10, 2023
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 90ac960 into autowarefoundation:main Apr 10, 2023
@satoshi-ota satoshi-ota deleted the fix/launch-path branch April 10, 2023 10:19
purewater0901 pushed a commit that referenced this pull request Apr 11, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants