Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mission_planner): add route updater #3334

Merged
merged 9 commits into from
Apr 10, 2023
Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Apr 10, 2023

Description

Add a route update that updates route of the route handler in default planner

🤖 Generated by Copilot at 1f1e50b

This pull request enables the default planner plugin to handle route information from the mission planner node. It adds an updateRoute method to the PlannerPlugin interface and implements it in the DefaultPlanner class. It also modifies the MissionPlanner class to call the updateRoute method of the planner plugin when the route changes.

Related links

Tests performed

Planning SImulator

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 10, 2023
@purewater0901 purewater0901 changed the title Feat/add route updater feat(mission_planner): add route updater Apr 10, 2023
@kosuke55
Copy link
Contributor

@purewater0901
nice! And how about resetting the route_lanelets when change_route() without args is called?

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.72 ⚠️

Comparison is base (51a8bad) 13.14% compared to head (ca37510) 12.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3334      +/-   ##
==========================================
- Coverage   13.14%   12.43%   -0.72%     
==========================================
  Files        1280     1368      +88     
  Lines       90724    95955    +5231     
  Branches    27969    27641     -328     
==========================================
+ Hits        11928    11930       +2     
- Misses      66128    71357    +5229     
  Partials    12668    12668              
Flag Coverage Δ *Carryforward flag
differential 20.90% <0.00%> (?)
total 12.43% <ø> (-0.72%) ⬇️ Carriedforward from 44b5e75

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ity_planner/src/scene_module/intersection/util.cpp 0.00% <ø> (ø)
...ocity_planner/src/scene_module/run_out/manager.cpp 0.00% <ø> (ø)
...n_planner/src/lanelet2_plugins/default_planner.cpp 22.11% <0.00%> (-0.78%) ⬇️
...on_planner/src/mission_planner/mission_planner.cpp 0.00% <0.00%> (ø)
planning/route_handler/src/route_handler.cpp 11.46% <ø> (ø)

... and 122 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@purewater0901
Copy link
Contributor Author

@kosuke55 If you looked at the change_route(), it is only used when clearing the route. So I guess we do not have to do specific process.

@kosuke55
Copy link
Contributor

@purewater0901
change_route() seems to reset just the goal but not the route, so route_lanelets of route_handler is still kept as the previous one.

@purewater0901
Copy link
Contributor Author

@kosuke55 Yes, the route handler still keeps the previous route. However, since there is no way to clear all of the member variables in the route handler, I could not clear the route

@kosuke55
Copy link
Contributor

@purewater0901
yes, I meant adding public clearRoute() in route_handler and use it in mission_planner, how do you think?

void RouteHandler::clearRoute(){
  route_lanelets_.clear();
  preferred_lanelets_.clear();
  start_lanelets_.clear();
  goal_lanelets_.clear();
  // and more?
}

@purewater0901
Copy link
Contributor Author

I add a clear function for route handler with this PR

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: yutaka <purewater0901@gmail.com>
…n/autoware.universe into feat/add-route-updater
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants