-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mission_planner): add route updater #3334
Conversation
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3334 +/- ##
==========================================
- Coverage 13.14% 12.43% -0.72%
==========================================
Files 1280 1368 +88
Lines 90724 95955 +5231
Branches 27969 27641 -328
==========================================
+ Hits 11928 11930 +2
- Misses 66128 71357 +5229
Partials 12668 12668
*This pull request uses carry forward flags. Click here to find out more.
... and 122 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@kosuke55 If you looked at the |
@purewater0901 |
@kosuke55 Yes, the route handler still keeps the previous route. However, since there is no way to clear all of the member variables in the route handler, I could not clear the route |
@purewater0901
|
I add a clear function for route handler with this PR |
Signed-off-by: yutaka <purewater0901@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…n/autoware.universe into feat/add-route-updater
Description
Add a route update that updates route of the route handler in default planner
🤖 Generated by Copilot at 1f1e50b
This pull request enables the default planner plugin to handle route information from the mission planner node. It adds an
updateRoute
method to thePlannerPlugin
interface and implements it in theDefaultPlanner
class. It also modifies theMissionPlanner
class to call theupdateRoute
method of the planner plugin when the route changes.Related links
Tests performed
Planning SImulator
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.