Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_planner): properly get common params in 'run_out' #3333

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Apr 10, 2023

Description

The run_out module in the behavior_velocity_planner node is currently broken and crashes if turned on.
The issue comes from the declaration of some parameters that are (i) incorrectly named (leading dot .) and (ii) already declared (for normal.min_jerk and normal.min_acc).

This issue was previously hidden by default parameters which were recently removed (#3201).

Tests performed

Start the simple_planning_simulator after setting launch_run_out: true (https://github.com/autowarefoundation/autoware_launch/blob/main/autoware_launch/config/planning/scenario_planning/lane_driving/behavior_planning/behavior_velocity_planner/behavior_velocity_planner.param.yaml#L12).

  • Without this PR: crash.
  • With this PR: no crash.

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem self-assigned this Apr 10, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 10, 2023
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.10 ⚠️

Comparison is base (e941684) 13.22% compared to head (6cabbb5) 13.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3333      +/-   ##
==========================================
- Coverage   13.22%   13.13%   -0.10%     
==========================================
  Files        1267     1277      +10     
  Lines       90182    90827     +645     
  Branches    27697    28055     +358     
==========================================
+ Hits        11928    11929       +1     
- Misses      65586    66217     +631     
- Partials    12668    12681      +13     
Flag Coverage Δ *Carryforward flag
differential 3.61% <0.00%> (?)
total 13.22% <ø> (+<0.01%) ⬆️ Carriedforward from 03246e7

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ocity_planner/src/scene_module/run_out/manager.cpp 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem enabled auto-merge (squash) April 10, 2023 06:48
@maxime-clem maxime-clem merged commit bd9f336 into autowarefoundation:main Apr 10, 2023
@maxime-clem maxime-clem deleted the fix/behavior_velocity_planner-run_out-wrong_params branch April 10, 2023 08:06
purewater0901 pushed a commit that referenced this pull request Apr 11, 2023
…t' (#3333)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants