Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lane_change): rename lane_change_utils namespace #3332

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Apr 10, 2023

Description

🤖 Generated by Copilot at 8527b7e

This pull request refactors the namespace of the lane change utility functions in the behavior path planner component. The old namespace lane_change_utils is replaced by util::lane_change for clarity and consistency. The change affects several header, source, and test files that use these functions for lane change planning and checking.

Tests performed

  1. Build success test
    • COMPILE_WITH_OLD_ARCHITECTURE=TRUE
    • COMPILE_WITH_OLD_ARCHITECTURE=FALSE

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 10, 2023
Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Again!

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e778e73) 12.41% compared to head (8527b7e) 12.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3332   +/-   ##
=======================================
  Coverage   12.41%   12.41%           
=======================================
  Files        1368     1368           
  Lines       96123    96123           
  Branches    27697    27697           
=======================================
  Hits        11931    11931           
  Misses      71526    71526           
  Partials    12666    12666           
Flag Coverage Δ *Carryforward flag
differential 5.26% <0.00%> (?)
total 12.41% <ø> (+<0.01%) ⬆️ Carriedforward from e778e73

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/src/scene_module/avoidance_by_lc/module.cpp 0.00% <0.00%> (ø)
...ane_change/external_request_lane_change_module.cpp 0.00% <0.00%> (ø)
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <0.00%> (ø)
...ehavior_path_planner/src/util/lane_change/util.cpp 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit a61ba13 into autowarefoundation:main Apr 10, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the refactor-lc-util-namespace branch April 10, 2023 06:40
purewater0901 pushed a commit that referenced this pull request Apr 11, 2023
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants