Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trtexec_vendor): support build with tensorrt 8.6 #3321

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Apr 8, 2023

Description

🤖 Generated by Copilot at f3ad26f

Refactor the CMake file for trtexec_vendor to make it more readable and maintainable. Use variables for the tensorrt version and remove unnecessary syntax.

Tests performed

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@wep21 wep21 requested a review from a team as a code owner April 8, 2023 16:40
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Apr 8, 2023
Copy link
Contributor

@yukke42 yukke42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I have checked with the command trtexec --onnx=(ros2 pkg prefix tensorrt_yolox --share)/data/yolox-tiny.onnx.

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.75 ⚠️

Comparison is base (b33d4bb) 13.14% compared to head (f3ad26f) 12.40%.

❗ Current head f3ad26f differs from pull request most recent head 2c05f70. Consider uploading reports for the commit 2c05f70 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3321      +/-   ##
==========================================
- Coverage   13.14%   12.40%   -0.75%     
==========================================
  Files        1278     1368      +90     
  Lines       90746    96191    +5445     
  Branches    27971    27724     -247     
==========================================
+ Hits        11928    11930       +2     
- Misses      66150    71594    +5444     
+ Partials    12668    12667       -1     
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 12.40% <ø> (-0.75%) ⬇️ Carriedforward from 1ca02e1

*This pull request uses carry forward flags. Click here to find out more.

see 129 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wep21 wep21 merged commit a58a46f into main Apr 10, 2023
@wep21 wep21 deleted the fix/build-trtexec-vendor branch April 10, 2023 09:11
purewater0901 pushed a commit that referenced this pull request Apr 11, 2023
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants