Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): prevent cancel at end of lane #3315

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Apr 7, 2023

Description

🤖 Generated by Copilot at 85921c0

Added a configurable buffer for the end of lane condition in the isNearEndOfLane function of the lane_change_module. This is to prevent lane change from cancelling when it is at the end of the lane.

Solve TIER IV internal link

Related links

None

Tests performed

Test the scenarios in TIER IV internal link

Notes for reviewers

🤖 Generated by Copilot at 85921c0

  • Add a backward length buffer for the end of lane condition in isNearEndOfLane function (link)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 7, 2023
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6e3dbac) 12.40% compared to head (85921c0) 12.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3315   +/-   ##
=======================================
  Coverage   12.40%   12.40%           
=======================================
  Files        1369     1369           
  Lines       96209    96203    -6     
  Branches    27729    27726    -3     
=======================================
  Hits        11931    11931           
+ Misses      71612    71606    -6     
  Partials    12666    12666           
Flag Coverage Δ *Carryforward flag
differential 5.23% <0.00%> (?)
total 12.40% <ø> (+<0.01%) ⬆️ Carriedforward from 6e3dbac

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...havior_path_planner/behavior_path_planner_node.hpp ∅ <ø> (∅)
...or_path_planner/src/behavior_path_planner_node.cpp 0.11% <0.00%> (ø)
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zulfaqar-azmi-t4
Copy link
Contributor Author

Degradation check result
TIER IV internal link

Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit e778e73 into autowarefoundation:main Apr 10, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the fix-lc-end-of-lane-cancel branch April 10, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants