Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mission_planner): add reroute interface for api #3298

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Apr 6, 2023

Description

Add reroute interface for api.
autowarefoundation/autoware#3406

Tests performed

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Apr 6, 2023
@isamu-takagi isamu-takagi self-assigned this Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b33d4bb) 13.14% compared to head (3ee1397) 13.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3298   +/-   ##
=======================================
  Coverage   13.14%   13.15%           
=======================================
  Files        1278     1277    -1     
  Lines       90746    90702   -44     
  Branches    27971    27971           
=======================================
+ Hits        11928    11930    +2     
+ Misses      66150    66105   -45     
+ Partials    12668    12667    -1     
Flag Coverage Δ *Carryforward flag
differential 15.55% <0.00%> (?)
total 13.15% <ø> (+<0.01%) ⬆️ Carriedforward from c9f8bf0

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...d_map/pointcloud_based_occupancy_grid_map_node.cpp 0.00% <ø> (ø)
...on_planner/src/mission_planner/mission_planner.cpp 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55
Copy link
Contributor

@kenji-miyake @yabuta @tkhmy
Could you please check this as a code owner of component_interface_specs?

@kenji-miyake
Copy link
Contributor

kenji-miyake commented Apr 10, 2023

@kosuke55 Saito-san will review it. I'll update the codeowner of component_interface_specs.
-> #3330

@kosuke55
Copy link
Contributor

@yukkysaito please check this PR:pray:

@yukkysaito
Copy link
Contributor

@kosuke55 @isamu-takagi Could you please resolve conflicts?

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@kosuke55 kosuke55 force-pushed the feat/mission-planner-reroute-api branch from 5c11e44 to 3ee1397 Compare April 10, 2023 06:00
@kosuke55
Copy link
Contributor

@yukkysaito sorry, I fixed conficts.

@yukkysaito
Copy link
Contributor

@mitsudome-r We need a little more discussion on the API side, don't we?

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi merged commit 5abb009 into autowarefoundation:main Apr 13, 2023
@isamu-takagi isamu-takagi deleted the feat/mission-planner-reroute-api branch April 13, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants