Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autonomous_emergency_braking): publish debug marker on base_link frame #3248

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Apr 3, 2023

Description

publish debug marker on base_link frame to avoid when transform map to base_link is failed

Related links

Tests performed

I confirmed the marker visualizes on base_link frame
image

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta requested review from TakaHoribe, purewater0901 and a team as code owners April 3, 2023 07:30
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Apr 3, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (70cf872) 12.33% compared to head (5641f38) 12.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3248      +/-   ##
==========================================
- Coverage   12.33%   12.28%   -0.06%     
==========================================
  Files        1363     1363              
  Lines       94810    94486     -324     
  Branches    27000    26992       -8     
==========================================
- Hits        11697    11608      -89     
+ Misses      70763    70530     -233     
+ Partials    12350    12348       -2     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 12.28% <ø> (-0.06%) ⬇️ Carriedforward from 70cf872

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
common/autoware_auto_geometry/src/spatial_hash.cpp 100.00% <ø> (ø)
...mmon/autoware_auto_geometry/test/src/test_area.cpp 65.38% <ø> (-1.29%) ⬇️
.../src/object_detection/detected_objects_display.cpp 0.00% <ø> (ø)
...n/src/object_detection/tracked_objects_display.cpp 0.00% <ø> (ø)
common/fake_test_node/src/fake_test_node.cpp 46.66% <ø> (-6.28%) ⬇️
common/fake_test_node/test/test_fake_test_node.cpp 44.00% <ø> (-4.15%) ⬇️
common/grid_map_utils/src/polygon_iterator.cpp 62.50% <ø> (-0.36%) ⬇️
common/kalman_filter/src/kalman_filter.cpp 0.00% <ø> (ø)
...mon/kalman_filter/src/time_delay_kalman_filter.cpp 0.00% <ø> (ø)
...motion_utils/src/vehicle/vehicle_state_checker.cpp 70.00% <ø> (-0.59%) ⬇️
... and 119 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ohta h-ohta merged commit c705f49 into main Apr 4, 2023
@h-ohta h-ohta deleted the h-ohta-patch-1 branch April 4, 2023 02:03
h-ohta added a commit to tier4/autoware.universe that referenced this pull request Apr 4, 2023
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Apr 7, 2023
h-ohta added a commit to tier4/autoware.universe that referenced this pull request Apr 13, 2023
…warefoundation#2793, autowarefoundation#3186, autowarefoundation#3248, autowarefoundation#3292) (#330)

* feat(control): add autonomous emergency braking module (autowarefoundation#2793)

* fix build error

* ci(pre-commit): autofix

* fix: fix lookup symbol error

* fix(autonomous_emergency_braking): fix typo (autowarefoundation#3186)

Update node.cpp

* fix(autonomous_emergency_braking): publish debug marker on base_link frame (autowarefoundation#3248)

* feat(autonomous_emergency_braking): keep collision information for user specified seconds (autowarefoundation#3292)

* feat(autonomous_emergency_braking): keep collision information for user specified seconds

* style(pre-commit): autofix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

---------

Co-authored-by: Yutaka Shimizu <43805014+purewater0901@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants