Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity_planner): delete default values #3201

Conversation

yamazakiTasuku
Copy link
Contributor

@yamazakiTasuku yamazakiTasuku commented Mar 29, 2023

Description

Removed default values defined in declare_parameter function.

The following parameters need to be added
stop_line_extend_length: 5.0
detection_area.hold_stop_margin_distance: 2.0
intersection.walkway.external_input_timeout: 1.0
intersection.merge_from_private.merge_from_private_area.stop_duration_sec: 1.0
stop_line.hold_stop_margin_distance: 2.0
stop_line.use_initialization_stop_line_state: false
stop_line.debug.show_stopline_collision_check: false
virtual_traffic_light.hold_stop_margin_distance: 0.0
Behavior velocity planner delete param.webm

⬇️ This PR must be merged before this PR.
autowarefoundation/autoware_launch#272

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 29, 2023
@satoshi-ota satoshi-ota self-assigned this Mar 29, 2023
@satoshi-ota
Copy link
Contributor

@yamazakiTasuku Additionally, please fix conflicts 🙏

@yamazakiTasuku yamazakiTasuku changed the title Behavior velocity planner delete param refactor(behavior_velocity_planner): delete default values Mar 29, 2023
yamazakiTasuku and others added 2 commits April 6, 2023 13:17
Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the behavior_velocity_planner_delete_param branch from ae3efb6 to c4e4fc6 Compare April 6, 2023 04:24
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota self-requested a review April 6, 2023 04:51
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that this module works well in Psim (my local env). LGTM.

@satoshi-ota satoshi-ota enabled auto-merge (squash) April 6, 2023 04:54
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (b1f8d1e) 12.45% compared to head (12a535f) 12.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3201      +/-   ##
==========================================
- Coverage   12.45%   12.45%   -0.01%     
==========================================
  Files        1365     1365              
  Lines       95328    95332       +4     
  Branches    27208    27212       +4     
==========================================
  Hits        11874    11874              
- Misses      70914    70918       +4     
  Partials    12540    12540              
Flag Coverage Δ *Carryforward flag
differential 3.89% <0.00%> (?)
total 12.47% <ø> (+0.02%) ⬆️ Carriedforward from b1f8d1e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...havior_path_planner/behavior_path_planner_node.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.12% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <ø> (ø)
...include/behavior_velocity_planner/planner_data.hpp 0.00% <0.00%> (ø)
...er/include/scene_module/scene_module_interface.hpp 0.00% <0.00%> (ø)
planning/behavior_velocity_planner/src/node.cpp 0.43% <0.00%> (-0.01%) ⬇️
...ty_planner/src/scene_module/blind_spot/manager.cpp 0.00% <0.00%> (ø)
...ity_planner/src/scene_module/crosswalk/manager.cpp 0.00% <0.00%> (ø)
...lanner/src/scene_module/detection_area/manager.cpp 0.00% <0.00%> (ø)
..._planner/src/scene_module/intersection/manager.cpp 0.00% <0.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota merged commit b78b17d into autowarefoundation:main Apr 6, 2023
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Apr 7, 2023
…oundation#3201)

* delete param

Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>

* fix(intersection): remove unnecessary namespace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(intersection): remove param

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>
Co-authored-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants