-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(behavior_velocity_planner): delete default values #3201
refactor(behavior_velocity_planner): delete default values #3201
Conversation
planning/behavior_velocity_planner/config/intersection.param.yaml
Outdated
Show resolved
Hide resolved
@yamazakiTasuku Additionally, please fix conflicts 🙏 |
planning/behavior_velocity_planner/src/scene_module/intersection/manager.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
ae3efb6
to
c4e4fc6
Compare
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that this module works well in Psim (my local env). LGTM.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3201 +/- ##
==========================================
- Coverage 12.45% 12.45% -0.01%
==========================================
Files 1365 1365
Lines 95328 95332 +4
Branches 27208 27212 +4
==========================================
Hits 11874 11874
- Misses 70914 70918 +4
Partials 12540 12540
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…oundation#3201) * delete param Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp> * fix(intersection): remove unnecessary namespace Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(intersection): remove param Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp> Co-authored-by: satoshi-ota <satoshi.ota928@gmail.com>
Description
Removed default values defined in declare_parameter function.
The following parameters need to be added
stop_line_extend_length: 5.0
detection_area.hold_stop_margin_distance: 2.0
intersection.walkway.external_input_timeout: 1.0
intersection.merge_from_private.merge_from_private_area.stop_duration_sec: 1.0
stop_line.hold_stop_margin_distance: 2.0
stop_line.use_initialization_stop_line_state: false
stop_line.debug.show_stopline_collision_check: false
virtual_traffic_light.hold_stop_margin_distance: 0.0
Behavior velocity planner delete param.webm
⬇️ This PR must be merged before this PR.
autowarefoundation/autoware_launch#272
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.