Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_planner): add out of lane module #3191

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Mar 28, 2023

Description

Add a new module to the behavior_velocity_planner to stop the ego vehicle from entering another lane containing other vehicles, which may cause collisions or near-collisions in some cases.

Corresponding autoware_launch PR: autowarefoundation/autoware_launch#269
Corresponding tier4_autoware_msgs PR: tier4/tier4_autoware_msgs#79

Related links

Tests performed

Evaluation reports:

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Mar 28, 2023
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -8.76 ⚠️

Comparison is base (dad675a) 12.37% compared to head (e55fafc) 3.61%.

Additional details and impacted files
@@            Coverage Diff            @@
##             main   #3191      +/-   ##
=========================================
- Coverage   12.37%   3.61%   -8.76%     
=========================================
  Files        1368      97    -1271     
  Lines       96006    7140   -88866     
  Branches    27555    3853   -23702     
=========================================
- Hits        11876     258   -11618     
+ Misses      71591    6688   -64903     
+ Partials    12539     194   -12345     
Flag Coverage Δ
differential 3.61% <0.00%> (?)
total ?
Impacted Files Coverage Δ
...de/scene_module/out_of_lane/lanelets_selection.hpp 0.00% <0.00%> (ø)
...anner/include/scene_module/out_of_lane/manager.hpp 0.00% <0.00%> (ø)
...planner/include/scene_module/out_of_lane/types.hpp 0.00% <0.00%> (ø)
planning/behavior_velocity_planner/src/node.cpp 0.42% <0.00%> (-0.01%) ⬇️
...ity_planner/src/scene_module/out_of_lane/debug.cpp 0.00% <0.00%> (ø)
...planner/src/scene_module/out_of_lane/decisions.cpp 0.00% <0.00%> (ø)
...planner/src/scene_module/out_of_lane/footprint.cpp 0.00% <0.00%> (ø)
...rc/scene_module/out_of_lane/lanelets_selection.cpp 0.00% <0.00%> (ø)
...y_planner/src/scene_module/out_of_lane/manager.cpp 0.00% <0.00%> (ø)
...src/scene_module/out_of_lane/overlapping_range.cpp 0.00% <0.00%> (ø)
... and 1 more

... and 1283 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxime-clem maxime-clem force-pushed the behavior_velocity_planner/out_of_lane branch from 0392560 to 72bffee Compare March 29, 2023 08:02
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Mar 29, 2023
@maxime-clem maxime-clem force-pushed the behavior_velocity_planner/out_of_lane branch 2 times, most recently from 3843d58 to 71441d5 Compare March 31, 2023 05:51
@maxime-clem maxime-clem marked this pull request as ready for review March 31, 2023 08:48
@maxime-clem maxime-clem force-pushed the behavior_velocity_planner/out_of_lane branch 3 times, most recently from 6fb50b3 to e56157c Compare April 4, 2023 07:07
@maxime-clem maxime-clem self-assigned this Apr 4, 2023
maxime-clem and others added 23 commits April 7, 2023 15:04
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem force-pushed the behavior_velocity_planner/out_of_lane branch from 813a0f9 to 70b4ee2 Compare April 7, 2023 07:17
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@takayuki5168 takayuki5168 merged commit c9f8bf0 into autowarefoundation:main Apr 10, 2023
@maxime-clem maxime-clem deleted the behavior_velocity_planner/out_of_lane branch May 29, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants