fix(behavior_path_planner): fix lane change speed #3091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yutaka <purewater0901@gmail.com>
purewater0901
requested review from
rej55,
kosuke55,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
zulfaqar-azmi-t4 and
a team
as code owners
github-actions
bot
added
the
component:planning
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3091 +/- ##
==========================================
- Coverage 12.25% 12.13% -0.13%
==========================================
Files 1358 1358
Lines 94724 95687 +963
Branches 26887 27620 +733
==========================================
Hits 11613 11613
- Misses 70853 71756 +903
- Partials 12258 12318 +60
*This pull request uses carry forward flags. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| } | ||
| const auto dist_from_end = target_lane_length - min_total_lane_changing_distance; | ||
| return std::min(dist_from_lc_start, dist_from_end); | ||
| return std::min(dist_from_lc_start, target_lane_length); |
There was a problem hiding this comment.
As mentioned, this changed created bug for the multiple lane change. Therefore, please help to change the code accordingly.
There was a problem hiding this comment.
Isn't it too short to do the double lane change?
Signed-off-by: yutaka <purewater0901@gmail.com>
…ation/autoware.universe into feat/fix-lane-change-speed
rej55
approved these changes
Mar 29, 2023
xianglunkai
pushed a commit
to xianglunkai/autoware.universe
that referenced
this pull request
Apr 3, 2023
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
ktro2828
pushed a commit
to ktro2828/autoware.universe
that referenced
this pull request
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Although autoware assumes the ego vehicle runs at a constant velocity while lane change, current code does not follow this rule. It assumes that the ego vehicle decelerates while doing lane change. This makes the vehicle speed unnecessary low while lane change.
In this PR, I changed the ego vehicle speed to a constant speed.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.