Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_planner): change names in lane change module #3083

Merged
merged 4 commits into from
Mar 16, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Mar 15, 2023

Description

Change function and variable names that have redundant names in the lane change module.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 15, 2023
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.81 ⚠️

Comparison is base (5ec84e3) 12.72% compared to head (072acda) 11.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3083      +/-   ##
==========================================
- Coverage   12.72%   11.91%   -0.81%     
==========================================
  Files        1231     1332     +101     
  Lines       87073    92933    +5860     
  Branches    24737    24735       -2     
==========================================
- Hits        11078    11076       -2     
- Misses      64515    70376    +5861     
- Partials    11480    11481       +1     
Flag Coverage Δ *Carryforward flag
differential 5.54% <0.00%> (?)
total 11.92% <ø> (-0.81%) ⬇️ Carriedforward from 82f1184

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ehavior_path_planner/src/util/lane_change/util.cpp 0.00% <0.00%> (ø)

... and 103 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

purewater0901 and others added 2 commits March 16, 2023 00:08
Signed-off-by: yutaka <purewater0901@gmail.com>
@rej55 rej55 enabled auto-merge (squash) March 16, 2023 00:07
@rej55 rej55 merged commit f210e40 into main Mar 16, 2023
@rej55 rej55 deleted the refactor/change-lc-names branch March 16, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants