Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_simulator_launch): fix occupancy grid map not appearing problem in psim #3081

Merged

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Mar 15, 2023

Description

Problem

occupancy grid map is not generated in latest changes.
This is due to:

  • psim should not use pointcloud based method since pointcloud based method yields both raw and obstacle pointclouds
  • fixed args in laserscan based launch.py due to unintended bugs

Changes

  • use laserscan-based method instead of pointcloud
    • fix some args to fit psim environment
  • fix laserscan based launch.py to make bool args changable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@github-actions github-actions bot added component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b93dbc5) 11.91% compared to head (7f5d667) 11.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3081   +/-   ##
=======================================
  Coverage   11.91%   11.91%           
=======================================
  Files        1332     1332           
  Lines       92940    92940           
  Branches    24737    24737           
=======================================
  Hits        11078    11078           
  Misses      70382    70382           
  Partials    11480    11480           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 11.91% <ø> (ø) Carriedforward from eab33e5

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the bugfix/simulator_occupancy_grid_map branch from 79fc95a to 7f5d667 Compare March 15, 2023 06:06
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168 takayuki5168 self-requested a review March 15, 2023 06:13
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi
Copy link
Contributor Author

YoshiRi commented Mar 15, 2023

Confirmed in both lsim and psim

@YoshiRi YoshiRi enabled auto-merge (squash) March 15, 2023 06:14
@soblin soblin changed the title bugfix(tier4_simulator_launch): fix occupancy grid map not appearing problem in psim fix(tier4_simulator_launch): fix occupancy grid map not appearing problem in psim Mar 15, 2023
@YoshiRi YoshiRi merged commit 5ec84e3 into autowarefoundation:main Mar 15, 2023
@YoshiRi YoshiRi deleted the bugfix/simulator_occupancy_grid_map branch March 15, 2023 08:19
soblin pushed a commit to tier4/autoware.universe that referenced this pull request May 26, 2023
…problem in psim (autowarefoundation#3081)

* fixed psim occupancy grid map problem

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix parameter designation

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants