-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tier4_simulator_launch): fix occupancy grid map not appearing problem in psim #3081
fix(tier4_simulator_launch): fix occupancy grid map not appearing problem in psim #3081
Conversation
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3081 +/- ##
=======================================
Coverage 11.91% 11.91%
=======================================
Files 1332 1332
Lines 92940 92940
Branches 24737 24737
=======================================
Hits 11078 11078
Misses 70382 70382
Partials 11480 11480
*This pull request uses carry forward flags. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
79fc95a
to
7f5d667
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Confirmed in both lsim and psim |
…problem in psim (autowarefoundation#3081) * fixed psim occupancy grid map problem Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix parameter designation Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Description
Problem
occupancy grid map is not generated in latest changes.
This is due to:
Changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.