Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_perception_launch): fix config path #3078

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Mar 14, 2023

Description

Due to the following PR's change to the config path of pointcloud_based_occupancy_grid_map , currently, the planning simulator does not work.
#3032

I fixed the config path for occupancy grid map. Not all the bug was fixed with this PR.

NOTE: occupancy grid map is launched from not only tier4_perception_launch but also tier4_simulator_launch for planning simulator.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Mar 14, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review March 14, 2023 17:55
@takayuki5168 takayuki5168 requested review from miursh, yukkysaito and a team as code owners March 14, 2023 17:55
@takayuki5168
Copy link
Contributor Author

@yukkysaito @miursh @YoshiRi
Could you review the PR? This PR should be merged quickly since currently the planning simulator does not work.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi
Copy link
Contributor

YoshiRi commented Mar 15, 2023

LGTM, but param_file path is already set in here?

@YoshiRi
Copy link
Contributor

YoshiRi commented Mar 15, 2023

@takayuki5168

Could you update below?

…launch

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168
Copy link
Contributor Author

@KeisukeShima Could you approve the PR as a code owner?

@takayuki5168 takayuki5168 merged commit b93dbc5 into autowarefoundation:main Mar 15, 2023
@takayuki5168 takayuki5168 deleted the fix/laserscan_based_occupancy_grid_map-config branch March 15, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants