Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): use previous module turn signal in waiting approval #3072

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Mar 14, 2023

Description

use previous module turn signal in waiting approval.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (be0929b) 11.86% compared to head (be64c8e) 11.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3072      +/-   ##
==========================================
- Coverage   11.86%   11.86%   -0.01%     
==========================================
  Files        1333     1333              
  Lines       92801    92808       +7     
  Branches    24660    24666       +6     
==========================================
  Hits        11014    11014              
- Misses      70372    70379       +7     
  Partials    11415    11415              
Flag Coverage Δ *Carryforward flag
differential 5.54% <0.00%> (?)
total 11.86% <ø> (+<0.01%) ⬆️ Carriedforward from be0929b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/include/behavior_path_planner/utilities.hpp 23.80% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <0.00%> (ø)
...ehavior_path_planner/src/util/lane_change/util.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utilities.cpp 7.52% <0.00%> (-0.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota enabled auto-merge (squash) March 14, 2023 04:07
@satoshi-ota satoshi-ota merged commit 4342bdc into autowarefoundation:main Mar 14, 2023
@satoshi-ota satoshi-ota deleted the fix/turn-signal-lane-change branch March 14, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants