fix(perception): add dependencies to traffic light nodes #3071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:perception
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3071 +/- ##
==========================================
+ Coverage 11.86% 12.85% +0.99%
==========================================
Files 1333 1213 -120
Lines 92807 85016 -7791
Branches 24665 23937 -728
==========================================
- Hits 11014 10932 -82
+ Misses 70378 62750 -7628
+ Partials 11415 11334 -81
*This pull request uses carry forward flags. Click here to find out more. see 195 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…ight nodes Signed-off-by: David Wong <david.wong@tier4.jp>
|
@satoshi-ota Could you review/approve this PR? (As a code owner) |
satoshi-ota
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before
When building using --packages-up-to, the build fails with a missing dependencies.
After
Build passes.
Environment: This issue occurred when building the TLR software stack and dependent packages (--packages-up-to jetson_tlr_launch in Humble).
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.